Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot modifying dependency URLs causes Git clone error after upgrading to PNPM 9.4.0 #10124

Open
CaoMeiYouRen opened this issue Jul 2, 2024 · 11 comments
Labels

Comments

@CaoMeiYouRen
Copy link

CaoMeiYouRen commented Jul 2, 2024

Hi ,
I noticed that after upgrading to PNPM 9.4.0, Dependabot is modifying the dependency URLs from https://codeload.github.com/ to git+https://git@github.com, which is causing the following error:

ERROR  Command failed with exit code 128: /usr/bin/git clone git@github.com:CaoMeiYouRen/rss-parser.git /home/runner/setup-pnpm/node_modules/.bin/store/v3/tmp/_tmp_1835_81cad7a39cafa01315f02c3d60683486

CaoMeiYouRen/rss-impact-server/pull/178

This seems to be related to the way PNPM handles Git dependencies.
I would like to know if it is related to this change

Originally posted by @CaoMeiYouRen in #10073 (comment)

@deivid-rodriguez
Copy link
Contributor

Seems related to #7851, or #7258. I did have an upstream patch to propose but I was not able to finish it and did not get much attention from upstream maintainers.

@deivid-rodriguez
Copy link
Contributor

I think pnpm/pnpm#8005 may have fixed this? If that's the case, #10058 just merged a few hours ago should've done the trick (assuming it's deployed already). Can you verify?

@CaoMeiYouRen
Copy link
Author

I think pnpm/pnpm#8005 may have fixed this? If that's the case, #10058 just merged a few hours ago should've done the trick (assuming it's deployed already). Can you verify?

I don't think so, dependabot continues to open incorrect pull requests. e.g.
https://github.com/CaoMeiYouRen/rss-impact-server/pull/191/files

@jonjanego jonjanego added the L: javascript:pnpm npm packages via pnpm label Jul 8, 2024
@abdulapopoola
Copy link
Member

@CaoMeiYouRen is this still happening? I see successful Dependabot PRs in that repo

@n3dst4
Copy link

n3dst4 commented Jul 9, 2024

Looks like they got rid of their git dependencies instead: CaoMeiYouRen/rss-impact-server@b50fd76

@abdulapopoola
Copy link
Member

@n3dst4 ; yes, you're right. Thanks for the pointer

@matteo-cristino
Copy link

matteo-cristino commented Jul 12, 2024

I bumped in the same issue, is there any update?

@ghost
Copy link

ghost commented Jul 12, 2024

Looks like they got rid of their git dependencies instead: CaoMeiYouRen/rss-impact-server@b50fd76

@eikowagenknecht
Copy link

Same problem for me. I opened an issue with pnpm before finding this one here: pnpm/pnpm#8343 Not sure if Dependabot or pnpm needs to fix this.

@GabrielGil
Copy link

I believe PNPM is not doing a good job with this as it also mixes my dependencies to use git instead of https://codeload.github.com every time the lockfile is updated, breaking the build because due a SHH error. I will need to downgrade to v8 in my project, until a clear solution is achieved :)

The same error of pnpm/pnpm#8343 I am experiencing.

Thanks for the great work of Dependabot and PNPM's teams 🙌 🙏

@gilest
Copy link

gilest commented Aug 12, 2024

Posted a workaround in pnpm/pnpm#8343 (comment)

davidtaylorhq added a commit to discourse/discourse that referenced this issue Sep 3, 2024
davidtaylorhq added a commit to discourse/discourse that referenced this issue Sep 3, 2024
krmax44 added a commit to okfde/fragdenstaat_de that referenced this issue Sep 23, 2024
dependabot creates corrupt lock file entries for git dependencies. wait until that issue is resolved. see dependabot/dependabot-core#10124
krmax44 added a commit to okfde/fragdenstaat_de that referenced this issue Sep 23, 2024
dependabot creates corrupt lock file entries for git dependencies. wait until that issue is resolved. see dependabot/dependabot-core#10124
bikubi pushed a commit to okfde/fragdenstaat_de that referenced this issue Sep 23, 2024
dependabot creates corrupt lock file entries for git dependencies. wait until that issue is resolved. see dependabot/dependabot-core#10124
krmax44 added a commit to okfde/froide that referenced this issue Oct 7, 2024
dependabot creates corrupt lock file entries for git dependencies. wait until that issue is resolved. see dependabot/dependabot-core#10124
krmax44 added a commit to okfde/froide that referenced this issue Oct 7, 2024
dependabot creates corrupt lock file entries for git dependencies. wait until that issue is resolved. see dependabot/dependabot-core#10124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Scoping
Development

No branches or pull requests

10 participants