Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot configure commit message case to match commitlint #1666

Closed
alerque opened this issue Feb 1, 2020 · 9 comments · Fixed by #5744
Closed

Cannot configure commit message case to match commitlint #1666

alerque opened this issue Feb 1, 2020 · 9 comments · Fixed by #5744
Labels
core 🍏 Relates to the dependabot-core library itself F: pull-requests Issues about Dependabot pull requests service 💁 Relates to Dependabot features GitHub provides T: feature-request Requests for new features

Comments

@alerque
Copy link

alerque commented Feb 1, 2020

My projects' commitlint specifications require both a prefix & scope as well as sentence-case for the actual message. It seems dependabot will use sentence-case when no prefix is used or lower case when it is, but I can't seem to get it to mix and match. This comment on a related issue seems to suggest is should be possible, but I can't figure out how.

I'm configuring commitlint using the YAML file option (.commitlintrc.yaml) rather than packages.json if that makes a difference.

Is there a way to set up the correct casing?

@alerque

This comment was marked as outdated.

@stale stale bot removed the stale label Apr 1, 2020
@kewisch
Copy link

kewisch commented Sep 13, 2021

Confirming this is still an issue. Would be great if dependabot was aware of commitlint configs and would apply sentence-case when it is provided. The message builder code seems to use a static "bump" or "update" string, I've found no use of upcase_first that would transform this into sentence case.

Does dependabot have a general policy about adapting behavior based on presence of config files to third party code? I'm guessing keeping that working across versions might be difficult, but maybe commitlint is somewhat in a special place. Alternatively, would it be reasonable to scour past commit messages and adapt to the same style there?

Would a PR on this issue be welcome by the maintainers?

@kewisch
Copy link

kewisch commented Sep 13, 2021

For anyone else finding this and looking for a workaround, see for example https://github.com/agilepathway/label-checker/pull/108/files

@alerque
Copy link
Author

alerque commented Sep 13, 2021

@kewisch That's cute — and useful if you are okay with giving the bot a free pass to violate project standards 😆. Next thing you know you'll be giving the bot that drives your car a free pass to park on your lawn because it can't be taught to stay on the concrete driveway.

@jurre jurre added F: pull-requests Issues about Dependabot pull requests T: feature-request Requests for new features core 🍏 Relates to the dependabot-core library itself service 💁 Relates to Dependabot features GitHub provides labels Nov 26, 2021
LucasLarson pushed a commit to LucasLarson/ConnectTheDots that referenced this issue Jul 25, 2022
“Bump” → “bump”:
dependabot/dependabot-core#1666
dependabot/dependabot-core#406

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
LucasLarson pushed a commit to LucasLarson/ConnectTheDots that referenced this issue Jul 26, 2022
“Bump” → “bump”:
dependabot/dependabot-core#1666
dependabot/dependabot-core#406

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
LucasLarson pushed a commit to LucasLarson/HQ9 that referenced this issue Jul 26, 2022
“Bump” → “bump”:
dependabot/dependabot-core#1666
dependabot/dependabot-core#406

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
LucasLarson pushed a commit to LucasLarson/dotfiles that referenced this issue Jul 27, 2022
“Bump” → “bump”:
dependabot/dependabot-core#1666
dependabot/dependabot-core#406

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
LucasLarson pushed a commit to LucasLarson/dotfiles that referenced this issue Jul 30, 2022
“Bump” → “bump”:
dependabot/dependabot-core#1666
dependabot/dependabot-core#406

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@cyberveseli
Copy link

Hey @alerque did you find solution to this problem?

@dependabot dependabot deleted a comment from stale bot Sep 16, 2022
@alerque
Copy link
Author

alerque commented Sep 16, 2022

No. So far I have to manually rewrite commit messages for everything dependabot submits, usually by squash-merging with a custom message.

In other news I hear most people's self driving cars usually end up parked on curbs because they can't configure them to get close to the curb without getting on it.

@deivid-rodriguez
Copy link
Contributor

I think #5744 should fix this problem!

@MikeDombo
Copy link

MikeDombo commented Oct 18, 2022

@deivid-rodriguez when should your change take effect? I just had Dependabot recreate a PR, but it still fails the commitlint due to having lines over 100 characters. ex: aws-greengrass/aws-greengrass-logging-java#131

Error: You have commit messages with errors

⧗   input: chore(deps): bump maven-shade-plugin from 3.2.2 to 3.4.0

Bumps [maven-shade-plugin](https://github.com/apache/maven-shade-plugin) from 3.2.2 to 3.4.0.
- [Release notes](https://github.com/apache/maven-shade-plugin/releases)
- [Commits](https://github.com/apache/maven-shade-plugin/compare/maven-shade-plugin-3.2.2...maven-shade-plugin-3.4.0)
✖   body's lines must not be longer than 100 characters [body-max-line-length]

@deivid-rodriguez
Copy link
Contributor

The related PR just fixed the commit message case as reported in this issue, there's no change other than that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core 🍏 Relates to the dependabot-core library itself F: pull-requests Issues about Dependabot pull requests service 💁 Relates to Dependabot features GitHub provides T: feature-request Requests for new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants