New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot configure commit message case to match commitlint #1666
Comments
This comment was marked as outdated.
This comment was marked as outdated.
Confirming this is still an issue. Would be great if dependabot was aware of commitlint configs and would apply Does dependabot have a general policy about adapting behavior based on presence of config files to third party code? I'm guessing keeping that working across versions might be difficult, but maybe commitlint is somewhat in a special place. Alternatively, would it be reasonable to scour past commit messages and adapt to the same style there? Would a PR on this issue be welcome by the maintainers? |
For anyone else finding this and looking for a workaround, see for example https://github.com/agilepathway/label-checker/pull/108/files |
@kewisch That's cute — and useful if you are okay with giving the bot a free pass to violate project standards 😆. Next thing you know you'll be giving the bot that drives your car a free pass to park on your lawn because it can't be taught to stay on the concrete driveway. |
“Bump” → “bump”: dependabot/dependabot-core#1666 dependabot/dependabot-core#406 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
“Bump” → “bump”: dependabot/dependabot-core#1666 dependabot/dependabot-core#406 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
“Bump” → “bump”: dependabot/dependabot-core#1666 dependabot/dependabot-core#406 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
“Bump” → “bump”: dependabot/dependabot-core#1666 dependabot/dependabot-core#406 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
“Bump” → “bump”: dependabot/dependabot-core#1666 dependabot/dependabot-core#406 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Hey @alerque did you find solution to this problem? |
No. So far I have to manually rewrite commit messages for everything dependabot submits, usually by squash-merging with a custom message. In other news I hear most people's self driving cars usually end up parked on curbs because they can't configure them to get close to the curb without getting on it. |
I think #5744 should fix this problem! |
@deivid-rodriguez when should your change take effect? I just had Dependabot recreate a PR, but it still fails the commitlint due to having lines over 100 characters. ex: aws-greengrass/aws-greengrass-logging-java#131
|
The related PR just fixed the commit message case as reported in this issue, there's no change other than that. |
My projects' commitlint specifications require both a prefix & scope as well as sentence-case for the actual message. It seems dependabot will use sentence-case when no prefix is used or lower case when it is, but I can't seem to get it to mix and match. This comment on a related issue seems to suggest is should be possible, but I can't figure out how.
I'm configuring commitlint using the YAML file option (
.commitlintrc.yaml
) rather thanpackages.json
if that makes a difference.Is there a way to set up the correct casing?
The text was updated successfully, but these errors were encountered: