Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict type Dependabot::Bundler::GemspecFinder #10004

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

raj-meka
Copy link
Contributor

@raj-meka raj-meka commented Jun 14, 2024

What are you trying to accomplish?

Sorbet Implementation for Bundler GemSpecFinder ruby file.

Anything you want to highlight for special attention from reviewers?

Please pay attention to the fixes in the Bundler GemSpecFinder ruby file.

How will you know you've accomplished your goal?

The sorbet rules will fire as needed.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.
  • [ ]

@raj-meka raj-meka requested a review from a team as a code owner June 14, 2024 18:59
@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label Jun 14, 2024
@raj-meka raj-meka requested a review from JamieMagee June 14, 2024 18:59
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Jun 14, 2024
@raj-meka raj-meka force-pushed the Strict-type-DependabotBundlerGemSpecFinder branch from 780d046 to 5a781ef Compare June 14, 2024 20:38
@raj-meka raj-meka requested a review from JamieMagee June 14, 2024 20:39
@JamieMagee JamieMagee force-pushed the Strict-type-DependabotBundlerGemSpecFinder branch from 5a781ef to 1a34219 Compare June 17, 2024 16:01
@raj-meka raj-meka force-pushed the Strict-type-DependabotBundlerGemSpecFinder branch from 1a34219 to a7b244b Compare June 17, 2024 18:04
@raj-meka raj-meka merged commit 663bc8e into main Jun 17, 2024
58 checks passed
@raj-meka raj-meka deleted the Strict-type-DependabotBundlerGemSpecFinder branch June 17, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ruby:bundler RubyGems via bundler sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants