Enabling RSpec/BeforeAfterAll Rubocop rule #10043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
L: dotnet:nuget
|
Redoing former PR #10006 |
brettfo
approved these changes
Jun 19, 2024
robaiken
approved these changes
Jun 21, 2024
GarryHurleyJr
force-pushed
the
GarryHurleyJr/enableBeforeAfterAll
branch
from
0925c2c
to
6200fd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rubydoc.info/gems/rubocop-rspec/1.15.0/RuboCop/Cop/RSpec/BeforeAfterAll
What are you trying to accomplish?
The BeforeAfterAll RSpec rule was disabled in some parts of the ecosystme. This PR will enable and fix those scenarios it identifies.
Anything you want to highlight for special attention from reviewers?
Please watch for code duplications or conflicts.
How will you know you've accomplished your goal?
The Rubocop rule will work and the tests will not fai afterwards.
Checklist
I have run the complete test suite to ensure all tests and linters pass.
I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
I have written clear and descriptive commit messages.
I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
I have ensured that the code is well-documented and easy to understand.