Enabling the RSpec BeforeAfterAll Rubocop rule

[GarryHurleyJr]

https://www.rubydoc.info/gems/rubocop-rspec/1.15.0/RuboCop/Cop/RSpec/BeforeAfterAll

What are you trying to accomplish?

The BeforeAfterAll RSpec rule was disabled in some parts of the ecosystme. This PR will enable and fix those scenarios it identifies.

Anything you want to highlight for special attention from reviewers?

Please watch for code duplications or conflicts.

How will you know you've accomplished your goal?

The Rubocop rule will work and the tests will not fai afterwards.

Checklist

• I have run the complete test suite to ensure all tests and linters pass.
• I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
• I have written clear and descriptive commit messages.
• I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
• I have ensured that the code is well-documented and easy to understand.

[GarryHurleyJr]

Some of the rubocops were mixed up in main, so with a merge from main, things got out of sync. This branch should reflect the rubocop status in main.

[jurre]

@GarryHurleyJr still looks like there are unrelated changes in this PR. Maybe easiest to just do a hard reset to main and re-apply the changes.

[GarryHurleyJr]

@GarryHurleyJr still looks like there are unrelated changes in this PR. Maybe easiest to just do a hard reset to main and re-apply the changes.

The problem is that PR #9820 re-added some other rubocop rules that had been removed. I have updated that here so that we are at least showing the proper status of rubocop_todo.yml. Alternatively, I coud peel out those changes into a separate PR to merge into main and keep this and other PR's clean.

[GarryHurleyJr]

#10041 contains the code that was muddying this PR.

[GarryHurleyJr]

creating a new PR for this issue