Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling RSpec MultipleDescribes and renaming errors_spec.rb file #10045

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

GarryHurleyJr
Copy link
Contributor

@GarryHurleyJr GarryHurleyJr commented Jun 19, 2024

Rework of PR #9743

https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecmultipledescribes

What are you trying to accomplish?

The RSpec/MultipleDescribes rubocop rule was disabled for the errors_spec.rb file. This PR replaces that file with an appropriately named file (RSpec/FilePath cop compliance) and fixes the multiple describes issue within by nesting the describe statements.

Anything you want to highlight for special attention from reviewers?

Rework of PR #9743

How will you know you've accomplished your goal?

This rule will effectively run on the whole ecosystem and no tests will be affected.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@GarryHurleyJr GarryHurleyJr force-pushed the GarryHurleyJr/enabeRSpecMultipleDescribes branch from 7975bba to 0aee57d Compare June 24, 2024 14:25
@GarryHurleyJr GarryHurleyJr merged commit d6325b3 into main Jun 24, 2024
121 checks passed
@GarryHurleyJr GarryHurleyJr deleted the GarryHurleyJr/enabeRSpecMultipleDescribes branch June 24, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants