Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling RSpec/MultipleDescribes #9743

Closed
wants to merge 24 commits into from
Closed

Enabling RSpec/MultipleDescribes #9743

wants to merge 24 commits into from

Conversation

robaiken
Copy link
Contributor

@robaiken robaiken requested a review from a team as a code owner May 15, 2024 16:49
@robaiken robaiken self-assigned this May 15, 2024
@robaiken robaiken linked an issue May 23, 2024 that may be closed by this pull request
Enable New RuboCop Cops #9573
Closed
@jurre
Copy link
Member

jurre commented Jun 13, 2024 •
edited by GarryHurleyJr
Loading

There seem to be unrelated changes in this PR? just ones made necessary by merges to avoid conflicts

@GarryHurleyJr
Copy link
Contributor

There seem to be unrelated changes in this PR? just ones made necessary by merges to avoid conflicts

I merged in main to keep the code fresh. Since there were conflicts, I fixed those.

landongrindheim and others added 4 commits June 14, 2024 17:46
@landongrindheim
Consider directory when doing grouped updates
9578df8 
When considering whether a pull request matches an existing pull
request, we should consider whether the directories match.
@landongrindheim
Feature flag directory comparison
992f41c
@landongrindheim
Add missing types
224573f
@GarryHurleyJr
Merge branch 'main' into robaiken/Enabling-RSpec-MultipleDescribes
7320a9b
@jurre
Copy link
Member

jurre commented Jun 18, 2024 •
edited
Loading

There seem to be unrelated changes in this PR? just ones made necessary by merges to avoid conflicts

I merged in main to keep the code fresh. Since there were conflicts, I fixed those.

If they were fixed, the unrelated changes would not be showing.

It might be easiest to do a hard reset to main and re-apply the changes.

@github-actions github-actions bot added L: ruby:bundler RubyGems via bundler L: python labels Jun 18, 2024
@GarryHurleyJr
Copy link
Contributor

There seem to be unrelated changes in this PR? just ones made necessary by merges to avoid conflicts

I merged in main to keep the code fresh. Since there were conflicts, I fixed those.

If they were fixed, the unrelated changes would not be showing.

It might be easiest to do a hard reset to main and re-apply the changes.

hard reset done, changes reapplied.

@GarryHurleyJr
Copy link
Contributor

There seem to be unrelated changes in this PR? just ones made necessary by merges to avoid conflicts

I merged in main to keep the code fresh. Since there were conflicts, I fixed those.

If they were fixed, the unrelated changes would not be showing.

It might be easiest to do a hard reset to main and re-apply the changes.

Pulled out unrelated code into a separate PR #10041 to avoidconfusion. WIll rebase after that PR is merged.

@GarryHurleyJr GarryHurleyJr mentioned this pull request Jun 19, 2024
Merged
5 tasks
@GarryHurleyJr
Copy link
Contributor

This PR is superseded by #10045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulapopoola abdulapopoola abdulapopoola left review comments

@jurre jurre jurre left review comments

@GarryHurleyJr GarryHurleyJr GarryHurleyJr left review comments

@JamieMagee JamieMagee JamieMagee approved these changes

Assignees

@robaiken robaiken

Labels
L: javascript L: python L: ruby:bundler RubyGems via bundler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable New RuboCop Cops
8 participants
@robaiken @jurre @GarryHurleyJr @abdulapopoola @JamieMagee @landongrindheim @sileht @raj-meka