Transform update_types in IgnoreCondition

[feelepxyz]

Moving the update_types transform from the config file parser to the
ignore condition making it easier to initialize IgnoreCondition without
fetching a config file.

Working towards being able to do this:

ignore_conditions = ignore_conditions.map do |ic|
  Dependabot::Config::IgnoreCondition.new(
    dependency_name: ic["dependency-name"],
    versions: [ic["version-requirement"]],
    update_types: ic["update-types"],
  )
end
Dependabot::Config::UpdateConfig.
  new(ignore_conditions: ignore_conditions).
  ignored_versions_for(dependency)

[thepwagner]

LGTM: I'd assumed these exact strings only mattered when parsed directly from the config file.

If we're going to pass the verbatim strings through the external parser+storage and back into here, this works. I'd assumed it would be converted at some point, and intended to use the symbol.

What I really wanted is an enum in the JVM or an iota constant in Golang. Symbols where my guess at how Ruby might follow the same pattern...
With similar biases, I'd dig if these magic strings were defined and referenced as constants instead of duplicated across the codebase. The pattern in 7375421#diff-67a26681133898ab39f6dac25dad58b8bfa751fd7245ec723c196f1184f93101R9 seemed pretty neat!

[feelepxyz]

If we're going to pass the verbatim strings through the external parser+storage and back into here, this works. I'd assumed it would be converted at some point, and intended to use the symbol.

It would be real nice to iterate towards moving all config file validation and parsing to core and using that code from api, this would make it easier to consolidate on transforms in one place. We could then fail jobs if the config is currently invalid which would increase visibility of these issues.

[thepwagner]

LGTM! Just a nit about the transform.

[thepwagner]

Suggested change

	update_types.map(&:downcase).map(&:strip).compact
	update_types.compact.map(&:downcase).map(&:strip)

Nit: this compact does nothing, as nil values have already raised?

irb(main):002:0> [nil].map(&:downcase)
(irb):2:in `map': undefined method `downcase' for nil:NilClass (NoMethodError)

I'm not sure if it should be refactored to be a guard for the map()s (the suggestion), or just removed

[thepwagner]

Question: should this transform happen in the ConfigFile / parsing logic?

We might be able to simplify by assuming the caller of IgnoreCondition has normalized these values: either through ConfigFile or the mysterious server-side parsing process.

[feelepxyz]

Good catch! Yeah true, might be better to move to the File class and rely on the api to have done this already