Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IgnoreCondition: severity #3552

Closed
wants to merge 2 commits into from
Closed

IgnoreCondition: severity #3552

wants to merge 2 commits into from

Conversation

thepwagner
Copy link
Contributor

Continuing #3513 and #3550 , as the string values like version-updates:semver-* suggest, "update types" should be bypassed when Dependabot is creating an update in response to a security alert.

This PR introduces the vapourware concept of security_severity to the lookup of ignored versions for a dependency: if set to a non-nil value, the current version-updates:* types will be ignored.
All we really need here is a boolean flag, like security_updates_only (as suggested by @feelepxyz). The idea of building the API around severity is to empower some fast-follow features like: update-types: ["security-updates:low-severity"].

@thepwagner thepwagner requested a review from a team as a code owner April 23, 2021 17:17
@thepwagner thepwagner self-assigned this Apr 23, 2021
@feelepxyz
Copy link
Contributor

I'm wondering if this is where we'll end up using security_severity with security-updates:low-severity. Would it make more sense to skip running the job altogether if the severity is ignored in api as all versions will need to be ignored? Although, if we set the ignored version to >= 0, it would return immediately here: https://github.com/dependabot/dependabot-core/blob/main/common/lib/dependabot/update_checkers/base.rb#L41

Leaning towards a simpler interface of security_updates_only and punt on the decision to figure out how severity ignores will work. Thoughts?

I might be getting into the weeds here, either interface would be straight forward to change.

@thepwagner thepwagner closed this Apr 26, 2021
@thepwagner thepwagner deleted the ignore-condition-severity branch April 26, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants