URL decode Nuget API v2 "next" link when paging version results #5174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Nuget repositories, such as JFrog's Artifactory, URL encode the "next" href link in the paged results. If the href is not URL decoded, the paging parameters are ignored and the first page is always returned. This change URL decodes the href before fetching the next page of version results.
jeffwidman
reviewed
May 23, 2022
There was a problem hiding this comment.
Thanks @tomcain!
This looks reasonable to me but I joined the team recently and still coming up to speed on Ruby so will get second pair of eyes from someone else on the team just to ensure I'm not missing something.
In the meantime, can you fix the CI failure here?
https://github.com/dependabot/dependabot-core/runs/6559358299?check_suite_focus=true
Ignore the other npm/yarn failure, it's unrelated.
brrygrdn
approved these changes
May 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5166
Some Nuget repositories, such as JFrog's Artifactory, URL encode the "next" href link in the paged results. If the href is not URL decoded, the paging parameters are ignored and the first page is always returned. This change URL decodes the href before fetching the next page of version results.