Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log when go mod tidy fails #6601

Merged
merged 1 commit into from Feb 6, 2023
Merged

Log when go mod tidy fails #6601

merged 1 commit into from Feb 6, 2023

Conversation

JohnTitor
Copy link
Contributor

Fixes #4445

@JohnTitor JohnTitor requested a review from a team as a code owner February 6, 2023 03:50
jeffwidman
jeffwidman reviewed Feb 6, 2023
View reviewed changes
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I just kickstarted CI for you.

Give me a day or two to inquire about the security risk of logging the actual error.

go_modules/lib/dependabot/go_modules/file_updater/go_mod_updater.rb Show resolved Hide resolved
@jeffwidman jeffwidman enabled auto-merge (squash) February 6, 2023 18:45
jeffwidman
jeffwidman approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship this! 🎉

Thanks again.

@jeffwidman jeffwidman merged commit d9a28c8 into dependabot:main Feb 6, 2023
@JohnTitor JohnTitor deleted the log-go-mod-tidy branch February 6, 2023 23:16
@JohnTitor
Copy link
Contributor Author

Awesome, thanks for checking/reviewing, too! It'd be great if you could let me know when it's deployed :)

@jeffwidman
Copy link
Member

I'll probably deploy it tomorrow, Friday at the very latest.

This was referenced Feb 8, 2023
Closed
Closed
alcere pushed a commit that referenced this pull request Feb 20, 2023
@JohnTitor
Log when go mod tidy fails (#6601)
596c8eb
@jeffwidman jeffwidman mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeikel yeikel yeikel left review comments

@jeffwidman jeffwidman jeffwidman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log when running go mod tidy fails
3 participants
@JohnTitor @jeffwidman @yeikel