[Updater] Extract creation of new group Pull Requests into a discrete class #7354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brrygrdn
changed the title
bdragon
approved these changes
May 22, 2023
updater/lib/dependabot/updater/operations/create_group_update_pull_request.rb
Outdated
Show resolved
Hide resolved
brrygrdn
force-pushed
the
brrygrdn/extract-group-creation
branch
from
501c042
to
1b90dc1
Compare
brrygrdn
force-pushed
the
brrygrdn/group-update-all-refreshes-existing-prs
branch
3 times, most recently
from
4ae5aaf
to
53f544c
Compare
brrygrdn
force-pushed
the
brrygrdn/extract-group-creation
branch
2 times, most recently
from
781729c
to
fccdd96
Compare
brrygrdn
changed the base branch from
brrygrdn/group-update-all-refreshes-existing-prs
to
main
brrygrdn
force-pushed
the
brrygrdn/extract-group-creation
branch
2 times, most recently
from
f8df887
to
7653370
Compare
This goes against the intend of a Dependency Snapshot being the Job enriched with data from parsing contents of the repository. Let's just use job.dependency_group_to_refresh when we need to
brrygrdn
force-pushed
the
brrygrdn/extract-group-creation
branch
from
7653370
to
62efaa8
Compare
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
…roup-creation [Updater] Extract creation of new group Pull Requests into a discrete class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from #7310This extracts
CreateGroupUpdatePullRequestas a sibling class toRefreshGroupUpdatePullRequestand removes all responsibility for actually processing groups into PullRequests fromGroupUpdateAllVersionsso its sole responsibility is co-ordination of which strategy to use for each group.