[Updater] GroupUpdateAllVersions now performs refreshes for existing PRs instead of deferring them to a separate job #7310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mctofu
approved these changes
May 12, 2023
brrygrdn
force-pushed
the
brrygrdn/group-update-all-refreshes-existing-prs
branch
from
7277d10
to
88ebaff
Compare
brrygrdn
force-pushed
the
brrygrdn/group-update-all-refreshes-existing-prs
branch
2 times, most recently
from
5f8f851
to
e8cff53
Compare
|
We are parking this change for now as it requires some API changes that we need to hammer out the right direction on to move to this model. |
This goes against the intend of a Dependency Snapshot being the Job enriched with data from parsing contents of the repository. Let's just use job.dependency_group_to_refresh when we need to
brrygrdn
force-pushed
the
brrygrdn/group-update-all-refreshes-existing-prs
branch
from
4ae5aaf
to
53f544c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our initial iteration of grouped update scheduled jobs we choose the following strategy:
GroupUpdateAllVersionsjob only runs for groups which do not have a pre-existing, open pull requestRefreshGroupUpdatePullRequestfor these existing open pull requestsThis approach optimised for avoiding a single Operation doing too much and prefer to run smaller jobs when we can, but a major drawback is it means that the primarily scheduled update job logs do not show these refreshes.
This is a pretty significant drawback as we currently do not do a great job of surfacing refresh/rebase logs in the UI.
Changes
This branch adds a small interface to allow the
RefreshGroupUpdatePullRequestto have data about an existing pull request to be injected as an 'overlay' on theDependabot::Jobin order to allowGroupUpdateAllVersionsto delegate to it to perform refresh operations in-line without having to incorporate the refresh logic directly.