[Updater] When a Dependency Group is refreshed as part of a scheduled GroupUpdateAllVersions, it defers rebasing #7432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #7310
When testing #7310 yesterday we realised that any attempt to 'rebase', i.e. call the
update_pull_request
endpoint, from within a scheduledGroupUpdateAllVersions
job fails as the endpoint expects the job to specify a single target PullRequest to update.After discussing this, we realised that having rebases happen within the scheduled job is something we can and should defer - rebases should honour the user configuration and only be triggered when the branch goes into conflict, it's not intentional nor well understood that we rebase during a schedule for some PRs right now.
This change course-corrects our approach so that the delegation to the
RefreshGroupUpdatePullRequest
will defer rebases but will replace or supersede PRs if the dependencies or versions involved have changed respectively.