Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test that fails when new versions are released #7580

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

jakecoffman
Copy link
Member

To permanently fix this, I've switch from matching a fixture as the result to using a regex to decide if the beginning of the line starts with the expected non-standard prefix. The content of the update isn't what is under test here, so I think this is good.

@jakecoffman jakecoffman requested a review from a team as a code owner July 18, 2023 15:26
@jakecoffman jakecoffman enabled auto-merge (squash) July 18, 2023 15:30
@jakecoffman jakecoffman merged commit 5536a0d into main Jul 18, 2023
86 checks passed
@jakecoffman jakecoffman deleted the jakecoffman/flake branch July 18, 2023 15:36
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just added a minor comment to potentially improve the new assertion.

brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants