Fix some swift updates failing when directory is configured
#7674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecoffman
approved these changes
Jul 31, 2023
The update checker temporarily tries to update versions, and then parses to resulting lockfile to figure out what the latest resolvable version is. To do this, it uses a modified manifest with unlocked depencies. This modified manifest was not inheriting the `directory` property from the original manifest and that was causing swift to be run from the wrong folder, and thus reparsing of the updated lockfile file. To fix that, make sure manifests use by the UpdateChecker inherit the `directory` property from the original manifests.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/swift-updates-with-dir
branch
from
6031260
to
741a3a6
Compare
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
…abot#7674) The update checker temporarily tries to update versions, and then parses to resulting lockfile to figure out what the latest resolvable version is. To do this, it uses a modified manifest with unlocked depencies. This modified manifest was not inheriting the `directory` property from the original manifest and that was causing swift to be run from the wrong folder, and thus reparsing of the updated lockfile file. To fix that, make sure manifests use by the UpdateChecker inherit the `directory` property from the original manifests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update checker temporarily tries to update versions, and then parses to resulting lockfile to figure out what the latest resolvable version is.
To do this, it uses a modified manifest with unlocked depencies.
This modified manifest was not inheriting the
directoryproperty from the original manifest and that was causing swift to be run from the wrong folder, and thus reparsing of the updated lockfile fail.To fix that, make sure manifests used by the UpdateChecker inherit the
directoryproperty from the original manifests.