Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sorbet and tapioca optional #8014

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Make sorbet and tapioca optional #8014

merged 1 commit into from
Sep 12, 2023

Conversation

JamieMagee
Copy link
Contributor

Sorbet currently doesn't support aarch64-linux. Unfortunately, this means that it doesn't work on Docker on macOS, unless you force --platform=linux/amd64 or DOCKER_DEFAULT_PLATFORM=linux/amd64.

This change makes sorbet and tapioca only install on supported platforms for now. This means that typechecking with srb tc will not work on Docker on macOS. However, while it's an optional, non-enforced, part of the project this is an acceptable trade-off.

Thankfully, it looks like official support for aarch64-linux is extremely close to being completed. So I anticipate this workaround will be shortlived.

References:

@JamieMagee JamieMagee requested a review from a team as a code owner September 12, 2023 16:58
@jurre
Copy link
Member

jurre commented Sep 12, 2023

Hmm, that's a bummer, I believe the whole core team is on OSX using Docker :( our codespaces setup is currently not really sufficient, so we might need to invest there a little bit depending on how quickly support for this lands

@JamieMagee
Copy link
Contributor Author

@jurre do you know how it's split between ARM macs and x86_64 macs? Cause it's only Docker on ARM macOS that would be unable to run srb tc locally.

Copy link
Member

@jakecoffman jakecoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this builds for me on ARM.

I suspect my editor will still have better completion even though I can't run Sorbet directly but we need a typed file first to test 😄

@jurre
Copy link
Member

jurre commented Sep 12, 2023

@jurre do you know how it's split between ARM macs and x86_64 macs? Cause it's only Docker on ARM macOS that would be unable to run srb tc locally.

Somewhere around 50/50 I believe

@jakecoffman jakecoffman enabled auto-merge (squash) September 12, 2023 17:10
@jakecoffman jakecoffman merged commit cfa26a8 into dependabot:main Sep 12, 2023
79 checks passed
@JamieMagee JamieMagee deleted the jamiemagee/optional-sorbet branch September 12, 2023 17:13
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants