Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sorbet VSCode extension #8018

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Add Sorbet VSCode extension #8018

merged 2 commits into from
Sep 12, 2023

Conversation

JamieMagee
Copy link
Contributor

This adds and enables the Sorbet VSCode extension as outlined in the Sorbet documetation.

This PR also disables Sorbet's watchman integration. That does limit Sorbet to only type-checking files that are edited in VSCode. But this would require editing the setup scripts and/or Dockerfiles. As Sorbet is still an optional part of the codebase, I think this is an acceptable trade-off for now.

Part of #7782

@JamieMagee JamieMagee requested a review from a team as a code owner September 12, 2023 19:16
@JamieMagee JamieMagee mentioned this pull request Sep 12, 2023
8 tasks
@jakecoffman jakecoffman enabled auto-merge (squash) September 12, 2023 19:28
@jakecoffman jakecoffman merged commit 338e005 into dependabot:main Sep 12, 2023
80 checks passed
@JamieMagee JamieMagee deleted the jamiemagee/vscode-extension branch September 12, 2023 21:59
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants