Fix CI #8105
Merged
Fix CI #8105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honeyankit
approved these changes
Sep 28, 2023
A new version of RuboCop was released, and broke our CI. We generally want to proactively update RuboCop, and not have to react to it breaking our CI. So I'd rather keep the version we run locked. To keep it locked, we have to use the `updater/Gemfile`, since that's the one that includes a lockfile. To do that we configure `BUNDLE_GEMFILE` in CI to use that. I decided to also add a rubocop binstub to make it easier to run rubocop either outside (like CI does) or inside our development image.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-ci
branch
from
494e669
to
f368cf1
Compare
|
Pushed one extra fix and this should be now green! |
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
A new version of RuboCop was released, and broke our CI. We generally want to proactively update RuboCop, and not have to react to it breaking our CI. So I'd rather keep the version we run locked. To keep it locked, we have to use the `updater/Gemfile`, since that's the one that includes a lockfile. To do that we configure `BUNDLE_GEMFILE` in CI to use that. I decided to also add a rubocop binstub to make it easier to run rubocop either outside (like CI does) or inside our development image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version of RuboCop was released, and broke our CI.
We generally want to proactively update RuboCop, and not have to react to it breaking our CI. So I'd rather keep the version we run locked.
To keep it locked, we have to use the
updater/Gemfile, since that's the one that includes a lockfile.To do that we configure
BUNDLE_GEMFILEin CI to use that.I decided to also add a rubocop binstub to make it easier to run rubocop either outside (like CI does) or inside our development image.