Added record update job error api back to capture unknown errors #8144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
honeyankit/report-unknown-error-to-update-job-error
branch
2 times, most recently
from
b10685c
to
9ecd92f
Compare
Co-authored-by: Ankit Kumar Honey <honeyankit@github.com>
deivid-rodriguez
force-pushed
the
honeyankit/report-unknown-error-to-update-job-error
branch
from
9ecd92f
to
aca7bfd
Compare
mctofu
approved these changes
Oct 5, 2023
honeyankit
deleted the
honeyankit/report-unknown-error-to-update-job-error
branch
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
…endabot#8144) * added update job error api back to file fetcher * added update job error api back to update_files_commands * added update job error api back to error_handler * added update job error api back to base command Co-authored-by: Ankit Kumar Honey <honeyankit@github.com> * Fixed the lint issue by removing unused method argument --------- Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds the new feature flag named
record_update_job_unknown_error. It has been created to be always enabled when running on our cloud infrastructure but remains inactive for GHES. The reason behind this differentiation is that older versions of GHES do not support the functionality of reporting unknown errors. This change ensures smooth operation across various environments without compromising on functionality where supported.This feature flag will be used to skip any
api_client.record_update_job_unknown_errorcall to capture the unknown error when running in GHES environment.This new feature flag
record_update_job_unknown_erroris already created in Dependabot-api and deployed to production.The PR which introduced the new api
record_update_job_unknown_errorfor reference.