Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix refreshing a grouped PR causes dependency duplication #8150

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

jakecoffman
Copy link
Member

@jakecoffman jakecoffman commented Oct 6, 2023

fixes #8149

In #8106 we accounted for existing grouped pull requests dependencies when running a grouped update job to prevent a dependency from appearing in multiple PRs.

This PR adds that same logic to the refresh so when Dependabot rebases or recreates a PR it doesn't duplicate the dependencies.

@jakecoffman jakecoffman marked this pull request as ready for review October 6, 2023 13:56
@jakecoffman jakecoffman requested a review from a team as a code owner October 6, 2023 13:56
Copy link
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jakecoffman jakecoffman merged commit 8e8953f into main Oct 6, 2023
97 checks passed
@jakecoffman jakecoffman deleted the jakecoffman/fix-refresh-group-duplication branch October 6, 2023 14:56
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grouped refresh causes dependency duplication
2 participants