Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grouped refresh causes dependency duplication #8149

Closed
jakecoffman opened this issue Oct 6, 2023 · 4 comments · Fixed by #8150
Closed

grouped refresh causes dependency duplication #8149

jakecoffman opened this issue Oct 6, 2023 · 4 comments · Fixed by #8150
Assignees
Labels
F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR

Comments

@jakecoffman
Copy link
Member

jakecoffman commented Oct 6, 2023

We're still seeing duplication [...]

For example, this grouped PR includes the libcnb-data and libcnb-package packages:
heroku/languages-github-actions#152

...even though they are covered by this (earlier in the Dependabot config definition) group:
heroku/languages-github-actions#148

Our Dependabot config is here:
https://github.com/heroku/languages-github-actions/blob/main/.github/dependabot.yml

And I reported this originally here:
#7939

Which was then marked as a duplicate of #7915 (which this PR closed).

Originally posted by @edmorley in #8106 (comment)

@jakecoffman jakecoffman self-assigned this Oct 6, 2023
@jakecoffman jakecoffman added the F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR label Oct 6, 2023
@jakecoffman
Copy link
Member Author

@edmorley Thanks for reporting that!

I forked the repo and Dependabot correctly created PRs with no duplication so it looks like #8106 was successful in that regard.

However once I ran the @dependabot recreate command on the rust-dependencies group PR it recreated and added back in the libcnb-data and libcnb-package dependencies.

I think I know what to do here, I'll try to get that fixed up today!

@jakecoffman
Copy link
Member Author

@edmorley This is fixed now. Since the repo is in a weird state, I suggest commenting @dependabot recreate on heroku/languages-github-actions#152 which should close the PR and put a new one up without duplication.

@edmorley
Copy link

edmorley commented Oct 6, 2023

@jakecoffman That was fast, thank you!

Looking great now - the @dependabot recreate successfully closed the old PR with dupes, then I manually triggered a new Dependabot run which opened a new PR with no dupes :-)
heroku/languages-github-actions#156

@edmorley
Copy link

edmorley commented Oct 9, 2023

I am seeing some old/superseded PRs not being closed though - for which I've filed #8162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants