properly resolve nuget search query when the api is versioned #8534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecoffman
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Thanks for the quick PR!
I confirmed this fixes dependabot update nuget udap-tools/udap-dotnet.
@brettfo Do you want someone from your team to approve as well or should I go ahead and deploy this?
|
This fix was pretty straight forward, it can be merged. |
brettfo
force-pushed
the
dev/brettfo/nuget-search-url-not-found
branch
from
5c5aa66
to
4672ef3
Compare
|
Looks like it didn't fix this case: |
|
Again this seems like an improvement to the error rate so I'll merge it. |
|
@jakecoffman Just created PR #8538 that should cover this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this comment, a NuGet repository's
:search_urlcan't be found if it has a version suffix like/3.0.0, etc. This PR checks in priority order for the specificSearchQueryServicevalue.