dynamically discover smoke tests #8551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh looks like there's a problem, the filter needs to be more strict: |
|
It works! The smoke test failures are expected due to a recent change in the PR body. There's a few tests missing which will be fixed by dependabot/smoke-tests#153 |
honeyankit
approved these changes
Dec 6, 2023
honeyankit
approved these changes
Dec 6, 2023
| @@ -43,8 +43,19 @@ jobs: | |||
| jq -c --argjson changes "$(cat changes.json)" '[.[] | select(.core as $p | $changes | index($p))]' .github/smoke-matrix.json > filtered.json | |||
| cat filtered.json | |||
|
|
|||
| # Curl the smoke-test tests directory to get a list of tests to run | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a new smoke test, we had to remember to also add it to this list of tests, which inevitably means we forgot.
This change pulls the list of tests from the smoke test so as long as it's on main it will be run!
It relies on convention that the "test" value in smoke-matrix.json matches the test name like so:
smoke-$test-.yaml.So I need to rename a few tests after merging this.