Test that file_parser reads .proj files #8746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
approved these changes
Jan 9, 2024
|
@bdragon Could I get a review on this? |
bdragon
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Looks good. I was just looking at the FileUpdater and this seems consistent with what it's doing:
dependabot-core/nuget/lib/dependabot/nuget/file_updater.rb
Lines 161 to 163 in 763f444
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if Dependabot is checking a directory which contains only .proj files (but that .proj file may reference a csproj higher up) it will fail with
No project file or packages.config!. That's because the regex used in this case is/\.[a-z]{2}proj$/, if we make the 2 characters optional we get the .proj file we were expecting.