directory is the job directory

[jakecoffman]

In #8405 I was under the impression that DependencyFile's directory was the directory of the file, and name was just the basename, but that's not the case. A DependencyFile's directory should always be the job (source) directory, and the name contains the relative path from the directory and also the filename.

Not sure what problem I was running into before, but removing job_directory and filtering on directory alone is passing the smoke tests, so this is confirmed!

[deivid-rodriguez]

So if I'm understanding correctly, even in a multidir group update, each dependency file will have the directory attribute set to the proper directory (from the ones included in the job).

[jakecoffman]

@deivid-rodriguez correct! For multi-directory fetches it loops over the directories:

dependabot-core/updater/lib/dependabot/file_fetcher_command.rb

Lines 100 to 108 in b05d6ed

	# Fetch dependency files for multiple directories
	def dependency_files_for_multi_directories
	@dependency_files_for_multi_directories ||= job.source.directories.flat_map do |dir|
	ff = with_retries { file_fetcher_for_directory(dir) }
	files = ff.files
	post_ecosystem_versions(ff) if should_record_ecosystem_versions?
	files
	end
	end

For each directory it sets the job source as that directory:

dependabot-core/updater/lib/dependabot/file_fetcher_command.rb

Line 79 in b05d6ed

source: job.source.clone.tap { |s| s.directory = directory_to_use },

[Nishnha]

I see, so the directory wasn't being set on DependencyFiles during grouped updates because we were referencing the job_directory instead? Glad you spotted this!