Centralize more Nuget calls #8849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
approved these changes
Jan 19, 2024
brettfo
approved these changes
Jan 19, 2024
jurre
reviewed
Jan 22, 2024
Comment on lines
+31
to
+41
| debug | ||
| gpgme | ||
| rake | ||
| rspec-its | ||
| rspec-sorbet | ||
| rubocop | ||
| rubocop-performance | ||
| rubocop-sorbet | ||
| stackprof | ||
| turbo_tests | ||
| vcr |
There was a problem hiding this comment.
It's not quite clear to me why these changes are needed, I would expect these to already be pulled in via the gemspec?
There was a problem hiding this comment.
They are unfortunately not. Running bundle exec turbo_tests in any directory currently gives
bundler: failed to load command: turbo_tests (/home/jamie/.asdf/installs/ruby/3.1.4/bin/turbo_tests)
/home/jamie/.asdf/installs/ruby/3.1.4/lib/ruby/gems/3.1.0/gems/bundler-2.5.3/lib/bundler/rubygems_integration.rb:265:in `block in replace_bin_path': can't find executable turbo_tests for gem turbo_tests. turbo_tests is not currently included in the bundle, perhaps you meant to add it to your Gemfile? (Gem::Exception)
I think it might actually be easier to get rid of deps_shared_with_common and just load the same development dependencies below
Dir.chdir(File.dirname(common_gemspec)) do
Gem::Specification.load(common_gemspec).development_dependencies.each do |dep|
- next unless deps_shared_with_common.include?(dep.name)
-
gem dep.name, *dep.requirement.as_list
end
end
jurre
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to split up my earlier PR into more manageable chunks, easy parts first.