Fix development dependency not being added if introduced by two gemspecs #7358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
approved these changes
Jan 6, 2024
|
@deivid-rodriguez do you happen to know when this will be released? |
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 17, 2024
Fix development dependency not being added if introduced by two gemspecs (cherry picked from commit eaef302)
|
Planning on doing it today! |
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 17, 2024
Fix development dependency not being added if introduced by two gemspecs (cherry picked from commit eaef302)
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 17, 2024
Fix development dependency not being added if introduced by two gemspecs (cherry picked from commit eaef302)
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 17, 2024
Fix development dependency not being added if introduced by two gemspecs (cherry picked from commit eaef302)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
If two gemspecs add the same development dependency with the same requirement, the dependency was being silently ignored.
What is your fix for the problem, implemented in this PR?
Fix the logic to consider the dependency.
Make sure the following tasks are checked