Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover parts of go_modules code with Sorbet #9338

Merged
merged 11 commits into from
Mar 22, 2024
Merged

Cover parts of go_modules code with Sorbet #9338

merged 11 commits into from
Mar 22, 2024

Conversation

ByAgenT
Copy link
Contributor

@ByAgenT ByAgenT commented Mar 20, 2024 •
edited
Loading

This PR adds strict Sorbet annotation in some files in go_modules and enables Sorbet Runtime.

@github-actions github-actions bot added the L: go:modules Golang modules label Mar 20, 2024
@ByAgenT ByAgenT added the sorbet 🍦 Relates to Sorbet types label Mar 20, 2024
@ByAgenT ByAgenT changed the title Add Sorbet to go_modules file_parser.rb and replace_stuber.rb Cover parts of go_modules code with Sorbet Mar 21, 2024
@ByAgenT ByAgenT marked this pull request as ready for review March 21, 2024 21:00
@ByAgenT ByAgenT requested a review from a team as a code owner March 21, 2024 21:00
@JamieMagee JamieMagee force-pushed the byagent/go-modules-file-parse-types branch from 42d4986 to a6dba48 Compare March 22, 2024 15:54
@abdulapopoola abdulapopoola merged commit 569d4ef into main Mar 22, 2024
63 checks passed
@abdulapopoola abdulapopoola deleted the byagent/go-modules-file-parse-types branch March 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulapopoola abdulapopoola abdulapopoola approved these changes

@JamieMagee JamieMagee JamieMagee approved these changes

@ryanbrandenburg ryanbrandenburg ryanbrandenburg approved these changes

Assignees
No one assigned
Labels
L: go:modules Golang modules sorbet 🍦 Relates to Sorbet types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ByAgenT @abdulapopoola @JamieMagee @ryanbrandenburg