Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop hiding exception raised by composer #9657
Stop hiding exception raised by composer #9657
Changes from 14 commits
adff15b
5da1fe1
be91073
e3bf86d
ff8c892
df0af0f
4925f2c
bf84d05
f763edd
b7ca065
fc0b827
667da5b
b86369b
6a4ac2e
312af66
8328573
398e260
d977648
78cf509
500e7b5
532da13
2f82f30
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it stand now, this text fixture is unused because the test that you added that used it was deleted... you'll want to either re-add that test or delete this fixture... my vote is for re-adding that test as I think it's important to communicate to the develeoper/test the scenario where Dependabot can't do anything because the native compiled extension is missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
handle_composer_errors
has a condition that checks for missing Native Extensions in the composer error message. If there is a missing Native extension, then it will be caught by this check:dependabot-core/composer/lib/dependabot/composer/update_checker/version_resolver.rb
Lines 266 to 275 in 78cf509
So it shouldn't be possible for this to happen