Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable RSpec/NamedSubject #9748

Merged
merged 37 commits into from
May 29, 2024
Merged

Enable RSpec/NamedSubject #9748

merged 37 commits into from
May 29, 2024

Conversation

robaiken
Copy link
Contributor

@robaiken robaiken self-assigned this May 16, 2024
@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label May 16, 2024
@github-actions github-actions bot added the L: rust:cargo Rust crates via cargo label May 16, 2024
@github-actions github-actions bot added the L: docker Docker containers label May 16, 2024
@github-actions github-actions bot added the L: elm Elm packages label May 16, 2024
@github-actions github-actions bot added the L: github:actions GitHub Actions label May 16, 2024
@github-actions github-actions bot added the L: go:modules Golang modules label May 16, 2024
@github-actions github-actions bot added the L: java:gradle Maven packages via Gradle label May 16, 2024
@github-actions github-actions bot added L: elixir:hex Elixir packages via hex L: java:maven Maven packages via Maven labels May 16, 2024
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label May 17, 2024
@github-actions github-actions bot added the L: dart:pub Dart packages via pub label May 17, 2024
@github-actions github-actions bot added the L: terraform Terraform packages label May 17, 2024
@github-actions github-actions bot added the L: php:composer Issues and code for Composer label May 17, 2024
@robaiken robaiken marked this pull request as ready for review May 17, 2024 15:25
@robaiken robaiken requested review from a team as code owners May 17, 2024 15:25
robaiken and others added 2 commits May 17, 2024 16:51
@robaiken @jurre
:gemspec -> :dependency
641a196 
Co-authored-by: Jurre <jurre@github.com>
@robaiken @jurre
:gemspec -> :dependency
85d5e61 
Co-authored-by: Jurre <jurre@github.com>
@robaiken robaiken linked an issue May 23, 2024 that may be closed by this pull request
Enable New RuboCop Cops #9573
Closed
@robaiken robaiken merged commit acf7fc4 into main May 29, 2024
121 checks passed
@robaiken robaiken deleted the robaiken/enable-RSpec-NameSubject branch May 29, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurre jurre jurre approved these changes

@JamieMagee JamieMagee JamieMagee approved these changes

Assignees

@robaiken robaiken

Labels
L: dart:pub Dart packages via pub L: devcontainers L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet L: elixir:hex Elixir packages via hex L: elm Elm packages L: github:actions GitHub Actions L: go:modules Golang modules L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven L: javascript L: php:composer Issues and code for Composer L: python L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo L: swift Swift packages L: terraform Terraform packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable New RuboCop Cops
3 participants
@robaiken @jurre @JamieMagee