Enable RSpec/NamedSubject

.rubocop_todo.yml

@@ -251,12 +251,6 @@ RSpec/MultipleExpectations:
 RSpec/MultipleMemoizedHelpers:
   Max: 30
 
-# Offense count: 500
-# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
-# SupportedStyles: always, named_only
-RSpec/NamedSubject:
-  Enabled: false
-
 # Offense count: 3871
 # Configuration parameters: AllowedGroups.
 RSpec/NestedGroups:

bundler/spec/dependabot/bundler/file_parser_spec.rb

@@ -739,12 +739,12 @@
       let(:dependency_files) { bundler_project_dependency_files("gemspec_loads_another") }
 
       describe "a development dependency loaded from an external gemspec" do
-        subject { dependencies.find { |d| d.name == "rake" } }
+        subject(:dependency) { dependencies.find { |d| d.name == "rake" } }
 
         it "is only loaded with its own gemspec as requirement" do
-          expect(subject.name).to eq("rake")
-          expect(subject.requirements.size).to eq(1)
-          expect(subject.requirements.first[:file]).to eq("another.gemspec")
+          expect(dependency.name).to eq("rake")
+          expect(dependency.requirements.size).to eq(1)
+          expect(dependency.requirements.first[:file]).to eq("another.gemspec")
         end
       end
     end

bundler/spec/dependabot/bundler/native_helpers_spec.rb

@@ -5,7 +5,7 @@
 require "dependabot/bundler/native_helpers"
 
 RSpec.describe Dependabot::Bundler::NativeHelpers do
-  subject { described_class }
+  subject(:native_helper) { described_class }
 
   describe ".run_bundler_subprocess" do
     let(:options) { {} }
@@ -16,7 +16,7 @@
       allow(Dependabot::SharedHelpers).to receive(:run_helper_subprocess)
 
       with_env("DEPENDABOT_NATIVE_HELPERS_PATH", native_helpers_path) do
-        subject.run_bundler_subprocess(
+        native_helper.run_bundler_subprocess(
           function: "noop",
           args: {},
           bundler_version: "2",

bundler/spec/dependabot/bundler/update_checker/latest_version_finder_spec.rb

@@ -54,7 +54,7 @@
   let(:rubygems_url) { "https://rubygems.org/api/v1/" }
 
   describe "#latest_version_details" do
-    subject { finder.latest_version_details }
+    subject(:latest_version_details) { finder.latest_version_details }
 
     context "with a rubygems source" do
       before do
@@ -110,7 +110,7 @@
         let(:raise_on_ignored) { true }
 
         it "doesn't raise an error" do
-          expect { subject }.to_not raise_error
+          expect { latest_version_details }.to_not raise_error
         end
       end
 
@@ -123,7 +123,7 @@
           let(:raise_on_ignored) { true }
 
           it "doesn't raise an error" do
-            expect { subject }.to_not raise_error
+            expect { latest_version_details }.to_not raise_error
           end
         end
       end
@@ -135,7 +135,7 @@
           let(:raise_on_ignored) { true }
 
           it "doesn't raise an error" do
-            expect { subject }.to_not raise_error
+            expect { latest_version_details }.to_not raise_error
           end
         end
       end
@@ -147,7 +147,7 @@
           let(:raise_on_ignored) { true }
 
           it "doesn't raise an error" do
-            expect { subject }.to_not raise_error
+            expect { latest_version_details }.to_not raise_error
           end
         end
       end
@@ -161,7 +161,7 @@
           let(:raise_on_ignored) { true }
 
           it "raises an error" do
-            expect { subject }.to raise_error(Dependabot::AllVersionsIgnored)
+            expect { latest_version_details }.to raise_error(Dependabot::AllVersionsIgnored)
           end
         end
       end
@@ -176,14 +176,14 @@
         let(:ignored_versions) { [">= 0"] }
 
         it "returns nil" do
-          expect(subject).to be_nil
+          expect(latest_version_details).to be_nil
         end
 
         context "when raise_on_ignored is set" do
           let(:raise_on_ignored) { true }
 
           it "raises an error" do
-            expect { subject }.to raise_error(Dependabot::AllVersionsIgnored)
+            expect { latest_version_details }.to raise_error(Dependabot::AllVersionsIgnored)
           end
         end
       end
@@ -558,7 +558,7 @@
   end
 
   describe "#lowest_security_fix_version" do
-    subject { finder.lowest_security_fix_version }
+    subject(:lowest_security_fix_version) { finder.lowest_security_fix_version }
 
     let(:current_version) { "1.1.0" }
     let(:security_advisories) do

bundler/spec/dependabot/bundler/update_checker/version_resolver_spec.rb

@@ -50,13 +50,13 @@
   let(:requirement_string) { ">= 0" }
 
   describe "#latest_resolvable_version_details" do
-    subject { resolver.latest_resolvable_version_details }
+    subject(:latest_resolvable_version_details) { resolver.latest_resolvable_version_details }
 
     context "with an unconfigured private rubygems source" do
       let(:dependency_files) { bundler_project_dependency_files("private_gem_source") }
 
       it "raises a PrivateSourceAuthenticationFailure error" do
-        expect { subject }
+        expect { latest_resolvable_version_details }
           .to raise_error(Dependabot::PrivateSourceAuthenticationFailure) do |error|
           expect(error.message).to include(": rubygems.pkg.github.com")
         end
@@ -108,7 +108,7 @@
 
           it "is updated" do
             skip("skipped due to https://github.com/dependabot/dependabot-core/issues/2364")
-            expect(subject.version).to eq(Gem::Version.new("1.10.9"))
+            expect(latest_resolvable_version_details.version).to eq(Gem::Version.new("1.10.9"))
           end
         end
       end
@@ -164,7 +164,7 @@
           let(:dependency_files) { bundler_project_dependency_files("bundler_specified") }
 
           it "returns nil as resolution returns the bundler version installed by core" do
-            expect(subject).to be_nil
+            expect(latest_resolvable_version_details).to be_nil
           end
         end
       end
@@ -185,7 +185,7 @@
         let(:dependency_files) { bundler_project_dependency_files("requires_bundler") }
 
         it "raises a DependencyFileNotResolvable error" do
-          expect { subject }
+          expect { latest_resolvable_version_details }
             .to raise_error(Dependabot::DependencyFileNotResolvable)
         end
       end
@@ -197,7 +197,7 @@
         let(:dependency_files) { bundler_project_dependency_files("requires_bundler") }
 
         it "resolves version" do
-          expect(subject[:version]).to eq(Gem::Version.new("3.0.0"))
+          expect(latest_resolvable_version_details[:version]).to eq(Gem::Version.new("3.0.0"))
         end
       end
 
@@ -355,7 +355,7 @@
         let(:dependency_files) { bundler_project_dependency_files("exec_error_no_lockfile") }
 
         it "raises a DependencyFileNotEvaluatable error" do
-          expect { subject }
+          expect { latest_resolvable_version_details }
             .to raise_error(Dependabot::DependencyFileNotEvaluatable)
         end
       end
@@ -366,7 +366,7 @@
       let(:requirement_string) { "~> 1.4" }
 
       it "raises a DependencyFileNotResolvable error" do
-        expect { subject }
+        expect { latest_resolvable_version_details }
           .to raise_error(Dependabot::DependencyFileNotResolvable)
       end
     end
@@ -375,7 +375,7 @@
       let(:dependency_files) { bundler_project_dependency_files("includes_requires_gemfile") }
 
       it "raises a useful error" do
-        expect { subject }
+        expect { latest_resolvable_version_details }
           .to raise_error(Dependabot::DependencyFileNotEvaluatable) do |error|
           # Test that the temporary path isn't included in the error message
           expect(error.message).to_not include("dependabot_20")
@@ -390,7 +390,7 @@
         let(:dependency_files) { bundler_project_dependency_files("path_source_not_reachable") }
 
         it "raises a PathDependenciesNotReachable error" do
-          expect { subject }
+          expect { latest_resolvable_version_details }
             .to raise_error(Dependabot::PathDependenciesNotReachable)
         end
       end

cargo/spec/dependabot/cargo/file_updater/lockfile_updater_spec.rb

@@ -228,7 +228,7 @@
         end
 
         it "raises a DependencyFileNotResolvable error" do
-          expect { subject }.to raise_error(Dependabot::DependencyFileNotResolvable) do |error|
+          expect { updated_lockfile_content }.to raise_error(Dependabot::DependencyFileNotResolvable) do |error|
             expect(error.message).to include("unexpected end of input while parsing major version")
           end
         end

cargo/spec/dependabot/cargo/update_checker/latest_version_finder_spec.rb

@@ -60,7 +60,7 @@
   let(:dependency_version) { "0.1.38" }
 
   describe "#latest_version" do
-    subject { finder.latest_version }
+    subject(:latest_version) { finder.latest_version }
 
     before do
       stub_request(:get, crates_url).to_return(status: 200, body: crates_response)
@@ -140,7 +140,7 @@
       let(:raise_on_ignored) { true }
 
       it "doesn't raise an error" do
-        expect { subject }.to_not raise_error
+        expect { latest_version }.to_not raise_error
       end
     end
 
@@ -153,7 +153,7 @@
         let(:raise_on_ignored) { true }
 
         it "doesn't raise an error" do
-          expect { subject }.to_not raise_error
+          expect { latest_version }.to_not raise_error
         end
       end
     end
@@ -167,7 +167,7 @@
         let(:raise_on_ignored) { true }
 
         it "raises an error" do
-          expect { subject }.to raise_error(Dependabot::AllVersionsIgnored)
+          expect { latest_version }.to raise_error(Dependabot::AllVersionsIgnored)
         end
       end
     end
@@ -179,14 +179,14 @@
         let(:raise_on_ignored) { true }
 
         it "doesn't raise an error" do
-          expect { subject }.to_not raise_error
+          expect { latest_version }.to_not raise_error
         end
       end
     end
   end
 
   describe "#lowest_security_fix_version" do
-    subject { finder.lowest_security_fix_version }
+    subject(:lowest_security_fix_version) { finder.lowest_security_fix_version }
 
     before do
       stub_request(:get, crates_url).to_return(status: 200, body: crates_response)
@@ -216,14 +216,14 @@
       let(:ignored_versions) { [">= 0"] }
 
       it "returns nil" do
-        expect(subject).to be_nil
+        expect(lowest_security_fix_version).to be_nil
       end
 
       context "when raise_on_ignored is enabled" do
         let(:raise_on_ignored) { true }
 
         it "raises an error" do
-          expect { subject }.to raise_error(Dependabot::AllVersionsIgnored)
+          expect { lowest_security_fix_version }.to raise_error(Dependabot::AllVersionsIgnored)
         end
       end
     end
@@ -298,7 +298,7 @@
     end
 
     describe "#latest_version" do
-      subject { finder.latest_version }
+      subject(:latest_version) { finder.latest_version }
 
       before do
         stub_request(:get, sparse_registry_url).to_return(status: 200, body: sparse_registry_response)
@@ -368,14 +368,14 @@
           let(:raise_on_ignored) { true }
 
           it "raises an error" do
-            expect { subject }.to raise_error(Dependabot::AllVersionsIgnored)
+            expect { latest_version }.to raise_error(Dependabot::AllVersionsIgnored)
           end
         end
       end
     end
 
     describe "#lowest_security_fix_version" do
-      subject { finder.lowest_security_fix_version }
+      subject(:lowest_security_fix_version) { finder.lowest_security_fix_version }
 
       before do
         stub_request(:get, sparse_registry_url).to_return(status: 200, body: sparse_registry_response)
@@ -405,14 +405,14 @@
         let(:ignored_versions) { [">= 0"] }
 
         it "returns nil" do
-          expect(subject).to be_nil
+          expect(lowest_security_fix_version).to be_nil
         end
 
         context "with raise_on_ignored" do
           let(:raise_on_ignored) { true }
 
           it "raises an error" do
-            expect { subject }.to raise_error(Dependabot::AllVersionsIgnored)
+            expect { lowest_security_fix_version }.to raise_error(Dependabot::AllVersionsIgnored)
           end
         end
       end