-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pushing changes in progress for git-lfs support adding to entire ecosystem. #9766
Closed
GarryHurleyJr
wants to merge
22
commits into
main
from
GarryHurleyJr/6039-add-support-in-dependabot-core-for-lfs-as-an-option-for-repositories
Closed
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
85ad379
Pushing changes in progress
GarryHurleyJr 528b2ad
Merge branch 'main' into GarryHurleyJr/6039-add-support-in-dependabot…
GarryHurleyJr b7858c5
Corrected the approach for determining the command string.
GarryHurleyJr 416f73c
cleanup of common files
GarryHurleyJr 1be323c
cleanup of common files
GarryHurleyJr fed7b21
Git class updates
GarryHurleyJr 859e451
Pushing changes in progress
GarryHurleyJr b58fb65
Corrected the approach for determining the command string.
GarryHurleyJr 00b1f37
cleanup of common files
GarryHurleyJr aa9e64e
cleanup of common files
GarryHurleyJr e610181
Git class updates
GarryHurleyJr bd0ba9c
Merge branch 'GarryHurleyJr/6039-add-support-in-dependabot-core-for-l…
GarryHurleyJr 512226c
sorbet fixes
GarryHurleyJr 3880844
sorbet fixes
GarryHurleyJr 7278432
sorbet fixes
GarryHurleyJr 6ac6646
sorbet fixes
GarryHurleyJr 32cf333
lint fixes
GarryHurleyJr 1fd1283
lint fixes
GarryHurleyJr 037657b
lint fixes
GarryHurleyJr f079add
lint fixes
GarryHurleyJr 5f555ef
lint fixes
GarryHurleyJr b5ec97b
lint fixes
GarryHurleyJr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jurre's suggestion is more idiomatic and won't incur the cost of shelling out, so I think you should incorporate that.
Just to call attention to it, shelling out to grep like this will return a non-zero exit if there's no match.
SharedHelpers.run_shell_command
will raise aHelperSubprocessFailed
exception on a non-zero exit, but here we're swallowing virtually any error that could occur and carrying on. The problem with this is it assumes the only thing that could go wrong is grep not finding a match, when there are other legitimate exceptions that could occur that we would want to propagate.If you find yourself writing
rescue StandardError
, it might be a good idea to ask if it's really necessary for what you're trying to do. Doing so will match any subclass ofStandardError
, which is the vast majority of errors you'll encounter (the Ruby docs onException
are good resource). If you truly want to check for theHelperSubprocessFailed
exception, rescue that class specifically so that other, unexpected exceptions are propagated correctly.