update nuget smoke test dependency files #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
commented
Mar 25, 2024
| @@ -535,32 +500,6 @@ output: | |||
| - name: xunit.abstractions | |||
| requirements: [] | |||
| version: 2.0.2 | |||
| - name: Microsoft.VisualStudio.Text.Data | |||
There was a problem hiding this comment.
The reported dependencies have changed because the Directory.Packages.props file contains dependencies that aren't listed in the relevant project.csproj so the new list is more accurate because only a .csproj can contain (or lead to) dependencies.
A Directory.Packages.props file could contain a line line this:
...
<PackageVersion Include="Some.Unused.Package" Version="1.2.3" />
...The previous version of the NuGet updater (see linked PR) would report this package as a dependency, but it really shouldn't be listed because the starting .csproj doesn't contain the corresponding <PackageReference> element and if the Version attribute was to be updated, no real change would occur in the final package resolution.
brettfo
force-pushed
the
dev/brettfo/nuget-dependencies
branch
from
92dea37
to
7fd07c9
Compare
ryanbrandenburg
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
Directory.Packages.propsis no longer explicitly listed as a dependency file. This is due to the dependency ultimately needing to be declared in a.csprojfile (or something imported by it) and it requires a value for the<TargetFramework>property, which aDirectory.Packages.propsfile does not contain.The resultant PR is still the same, though, and may end up modifying the package version in
Directory.Packages.props.This corresponds to dependabot/dependabot-core#9347 and must be taken in parallel.