Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update nuget smoke test dependency files #197

Merged
merged 1 commit into from
Mar 26, 2024
Merged

update nuget smoke test dependency files #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions tests/smoke-nuget-central-package-management.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@ output:
- dependencies
requirement: 13.0.1
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 13.0.1
source: null
version: 13.0.1
- name: Microsoft.CSharp
requirements: []
Expand Down Expand Up @@ -215,11 +210,6 @@ output:
- dependencies
requirement: 13.0.1
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 13.0.1
source: null
previous-version: 13.0.1
requirements:
- file: project.csproj
Expand All @@ -231,15 +221,6 @@ output:
source_url: null
type: nuget_repo
url: https://api.nuget.org/v3/index.json
- file: Directory.Packages.props
groups:
- dependencies
requirement: 13.0.3
source:
nuspec_url: https://api.nuget.org/v3-flatcontainer/newtonsoft.json/13.0.3/newtonsoft.json.nuspec
source_url: null
type: nuget_repo
url: https://api.nuget.org/v3/index.json
version: 13.0.3
updated-dependency-files:
- content: |-
Expand Down
79 changes: 2 additions & 77 deletions tests/smoke-nuget-potential-downgrade.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,6 @@ output:
- dependencies
requirement: 17.6.3
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 17.6.3
source: null
version: 17.6.3
- name: Microsoft.VisualStudio.Sdk.TestFramework
requirements:
Expand All @@ -52,11 +47,6 @@ output:
- dependencies
requirement: 17.2.7
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 17.2.7
source: null
version: 17.2.7
- name: Microsoft.VisualStudio.Sdk.TestFramework.Xunit
requirements:
Expand All @@ -65,11 +55,6 @@ output:
- dependencies
requirement: 17.2.7
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 17.2.7
source: null
version: 17.2.7
- name: Moq
requirements:
Expand All @@ -78,11 +63,6 @@ output:
- dependencies
requirement: 4.18.2
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 4.18.2
source: null
version: 4.18.2
- name: xunit.runner.visualstudio
requirements:
Expand All @@ -91,11 +71,6 @@ output:
- dependencies
requirement: 2.5.0
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 2.5.0
source: null
version: 2.5.0
- name: xunit
requirements:
Expand All @@ -104,11 +79,6 @@ output:
- dependencies
requirement: 2.5.0
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 2.5.0
source: null
version: 2.5.0
- name: Microsoft.TestPlatform.TestHost
requirements: []
Expand Down Expand Up @@ -351,13 +321,8 @@ output:
requirements: []
version: 6.0.0
- name: Microsoft.VisualStudio.Shell.15.0
requirements:
- file: Directory.Packages.props
groups:
- dependencies
requirement: 17.6.36389
source: null
version: 17.6.36389
requirements: []
version: 17.2.32505.113
- name: Microsoft.VisualStudio.Shell.Framework
requirements: []
version: 17.2.32505.113
Expand Down Expand Up @@ -535,32 +500,6 @@ output:
- name: xunit.abstractions
requirements: []
version: 2.0.2
- name: Microsoft.VisualStudio.Text.Data
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reported dependencies have changed because the Directory.Packages.props file contains dependencies that aren't listed in the relevant project.csproj so the new list is more accurate because only a .csproj can contain (or lead to) dependencies.

A Directory.Packages.props file could contain a line line this:

...
<PackageVersion Include="Some.Unused.Package" Version="1.2.3" />
...

The previous version of the NuGet updater (see linked PR) would report this package as a dependency, but it really shouldn't be listed because the starting .csproj doesn't contain the corresponding <PackageReference> element and if the Version attribute was to be updated, no real change would occur in the final package resolution.

requirements:
- file: Directory.Packages.props
groups:
- dependencies
requirement: 17.6.268
source: null
version: 17.6.268
- name: Microsoft.IO.Redist
requirements: []
version: 6.0.0
- name: System.Drawing.Common
requirements: []
version: 7.0.0
- name: Microsoft.Win32.SystemEvents
requirements: []
version: 7.0.0
- name: System.Security.Cryptography.ProtectedData
requirements: []
version: 7.0.0
- name: Microsoft.NET.StringTools
requirements: []
version: 17.4.0
- name: Microsoft.VisualStudio.CoreUtility
requirements: []
version: 17.6.268
dependency_files:
- /nuget/potential-downgrade/project.csproj
- /nuget/potential-downgrade/Directory.Packages.props
Expand All @@ -577,11 +516,6 @@ output:
- dependencies
requirement: 17.2.7
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 17.2.7
source: null
previous-version: 17.2.7
requirements:
- file: project.csproj
Expand All @@ -593,15 +527,6 @@ output:
source_url: null
type: nuget_repo
url: https://api.nuget.org/v3/index.json
- file: Directory.Packages.props
groups:
- dependencies
requirement: 17.6.16
source:
nuspec_url: https://api.nuget.org/v3-flatcontainer/microsoft.visualstudio.sdk.testframework.xunit/17.6.16/microsoft.visualstudio.sdk.testframework.xunit.nuspec
source_url: null
type: nuget_repo
url: https://api.nuget.org/v3/index.json
version: 17.6.16
updated-dependency-files:
- content: |
Expand Down
52 changes: 0 additions & 52 deletions tests/smoke-nuget-resolvability.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,6 @@ output:
- dependencies
requirement: 5.0.2
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 5.0.2
source: null
version: 5.0.2
- name: Microsoft.Extensions.Diagnostics.HealthChecks
requirements:
Expand All @@ -50,11 +45,6 @@ output:
- dependencies
requirement: 5.0.17
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 5.0.17
source: null
version: 5.0.17
- name: Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions
requirements: []
Expand Down Expand Up @@ -266,11 +256,6 @@ output:
- dependencies
requirement: 5.0.2
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 5.0.2
source: null
previous-version: 5.0.2
requirements:
- file: A/A.csproj
Expand All @@ -291,15 +276,6 @@ output:
source_url: null
type: nuget_repo
url: https://api.nuget.org/v3/index.json
- file: Directory.Packages.props
groups:
- dependencies
requirement: 7.0.0
source:
nuspec_url: https://api.nuget.org/v3-flatcontainer/aspnetcore.healthchecks.rabbitmq/7.0.0/aspnetcore.healthchecks.rabbitmq.nuspec
source_url: null
type: nuget_repo
url: https://api.nuget.org/v3/index.json
version: 7.0.0
- name: Microsoft.Extensions.Diagnostics.HealthChecks
previous-requirements:
Expand All @@ -308,11 +284,6 @@ output:
- dependencies
requirement: 5.0.17
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 5.0.17
source: null
previous-version: 5.0.17
requirements:
- file: B/B.csproj
Expand All @@ -324,15 +295,6 @@ output:
source_url: null
type: nuget_repo
url: https://api.nuget.org/v3/index.json
- file: Directory.Packages.props
groups:
- dependencies
requirement: 7.0.9
source:
nuspec_url: https://api.nuget.org/v3-flatcontainer/microsoft.extensions.diagnostics.healthchecks/7.0.9/microsoft.extensions.diagnostics.healthchecks.nuspec
source_url: null
type: nuget_repo
url: https://api.nuget.org/v3/index.json
version: 7.0.9
updated-dependency-files:
- content: |-
Expand Down Expand Up @@ -459,11 +421,6 @@ output:
- dependencies
requirement: 5.0.17
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 5.0.17
source: null
previous-version: 5.0.17
requirements:
- file: B/B.csproj
Expand All @@ -475,15 +432,6 @@ output:
source_url: null
type: nuget_repo
url: https://api.nuget.org/v3/index.json
- file: Directory.Packages.props
groups:
- dependencies
requirement: 7.0.9
source:
nuspec_url: https://api.nuget.org/v3-flatcontainer/microsoft.extensions.diagnostics.healthchecks/7.0.9/microsoft.extensions.diagnostics.healthchecks.nuspec
source_url: null
type: nuget_repo
url: https://api.nuget.org/v3/index.json
version: 7.0.9
updated-dependency-files:
- content: |-
Expand Down
5 changes: 0 additions & 5 deletions tests/smoke-nuget-transitive-pinning.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,6 @@ output:
- dependencies
requirement: 3.1.3
source: null
- file: Directory.Packages.props
groups:
- dependencies
requirement: 3.1.3
source: null
version: 3.1.3
- name: Microsoft.Extensions.Logging.Abstractions
requirements: []
Expand Down