Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download link on the document does not work #3225

Closed
hirockhirock opened this issue Jul 27, 2022 · 12 comments
Closed

Download link on the document does not work #3225

hirockhirock opened this issue Jul 27, 2022 · 12 comments

Comments

@hirockhirock
Copy link

hirockhirock commented Jul 27, 2022

  • Deployer version: 6.x
  • Deployment OS: Any

Download link for 6.x which is on the installation document (v6.x) does not work.
It returns 404 now.

curl -LO https://deployer.org/deployer.phar

I believe many developers using deployer on GitHub Actions use the link.
Is it no longer supported?

@antonmedv
Copy link
Member

Yes, looks like v7 release broke that link. Will fix, but notice, this link will be pointing to v7.

@pyr0hu
Copy link

pyr0hu commented Jul 27, 2022

Will there be a download link for 6.x?

@antonmedv
Copy link
Member

We have plenty of links: https://deployer.org/download ;)

@antonmedv
Copy link
Member

Or should /deployer.phar be always pointing to v6? 🤨

@pyr0hu
Copy link

pyr0hu commented Jul 27, 2022

@antonmedv great, thanks! The 6.x docs just mentioned https://deployer.org/deployer.phar so it was a bit confusing

@PimButton
Copy link

@antonmedv this is also breaking the Github Action that uses Deployer: deployphp/action#40

@alanaasmaa
Copy link

Or should /deployer.phar be always pointing to v6? 🤨

I would suggest to keep /deployer.phar to v6 because documents are suggested to use this for ages. And might brake a lot of things.

maybe /deployer-7latest.phar or something for latest 7 version.

@antonmedv
Copy link
Member

Yes, gonna pin /deployer.phar to v6.8.0, permanently)

@sandermarechal
Copy link

This broke my CI images as well. Will there be custom links for v6-latest and v7-latest? I don't want to pin to a specific patch release

@antonmedv
Copy link
Member

Probably for v7 there will be another link.

@hirockhirock
Copy link
Author

The link works correctly now. Thanks!

@Amunak
Copy link

Amunak commented Jul 28, 2022

You might want to consider using the same scheme as Composer: having latest-stable (latest major version), latest-7.x (latest v7), latest-6.8.x (latest 6.8LTS), ... See https://getcomposer.org/download/, section "Manual download".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants