Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fillna(0) workaround for artifacts without coordinates #5

Open
deppen8 opened this issue May 15, 2018 · 0 comments
Open

fillna(0) workaround for artifacts without coordinates #5

deppen8 opened this issue May 15, 2018 · 0 comments
Labels
code adjacent Not necessarily a coding problem, but has implications for code database Related to database design or queries leiap.spatial Related to leiap.spatial

Comments

@deppen8
Copy link
Owner

deppen8 commented May 15, 2018

When importing artifacts from the database, 10 of them did not have corresponding survey points. This raises a couple of questions:

  1. How did these artifacts get entered if there are no corresponding points? Were the points deleted accidentally?
  2. What should we do about it?

For now, I have added a .fillna(0) to the Eastings and Northings in the leiap.spatial.find_geo_field() function. This allows the spatial join (gpd.sjoin()) to proceed without throwing an error, but it will cause headaches later if you try to map these artifacts, so it is not ideal behavior.

For the record, these are the artifacts:

  • 160060-44-202-001
  • 160060-44-202-002
  • 160060-44-202-003
  • 160060-44-203-001
  • 160060-44-203-002
  • 160060-44-204-001
  • 160060-44-204-002
  • 18038b-65-003-001
  • 18038b-65-003-002
  • 18038b-65-003-003
@deppen8 deppen8 added leiap.spatial Related to leiap.spatial code adjacent Not necessarily a coding problem, but has implications for code database Related to database design or queries labels May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code adjacent Not necessarily a coding problem, but has implications for code database Related to database design or queries leiap.spatial Related to leiap.spatial
Projects
None yet
Development

No branches or pull requests

1 participant