Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadows completely disappear when it's raining #33

Closed
depressed-pho opened this issue Dec 28, 2018 · 3 comments
Closed

Shadows completely disappear when it's raining #33

depressed-pho opened this issue Dec 28, 2018 · 3 comments
Labels
bug Something isn't working currently impossible Feature request of something impossible, or an unfixable bug

Comments

@depressed-pho
Copy link
Owner

We are currently disabling shadows when a fog exists, because the seafloor will get unacceptably dark otherwise (because of water shadows). The depth of shadows does need to decrease, as there are many particles to scatter light, but it shouldn't drop to zero. I really want to improve this situation.

Ideally, water should not make such a dense shadows but I don't think we can tweak the light map itself. We will still have to resort to a hack, such as using 1 - fogColor.a instead of fogColor.a as the base depth of shadow.

@depressed-pho depressed-pho added the bug Something isn't working label Dec 28, 2018
@depressed-pho
Copy link
Owner Author

Or perhaps just 0.5 if fogColor.a > 0, and 1.0 otherwise?

@depressed-pho depressed-pho added the currently impossible Feature request of something impossible, or an unfixable bug label Dec 29, 2018
@depressed-pho
Copy link
Owner Author

Or we could possibly use the time-dependent daylight level to detect rain.

@depressed-pho
Copy link
Owner Author

After rethinking this issue I came to a conclusion that we should close it now. See also #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working currently impossible Feature request of something impossible, or an unfixable bug
Projects
None yet
Development

No branches or pull requests

1 participant