Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

회원가입 - api mutation & 기능 연동 #214

Merged
merged 9 commits into from
May 13, 2022
Merged

회원가입 - api mutation & 기능 연동 #214

merged 9 commits into from
May 13, 2022

Conversation

ddarkr
Copy link
Collaborator

@ddarkr ddarkr commented May 13, 2022

⛳️작업 내용

  • login
    • 로그인 폼 초기 상태에서 체크 표시 수정
  • signup
    • 이메일 가입 여부 확인 후 메일 전송 뮤테이션 적용
  • signup/sent-email
    • 이메일 승인 여부 확인 후 모달 띄우기 구현
  • signup/email-verified
    • 가입 완료 로직
    • 문제점1: signupSuccess effect 안에서 router.push가 안됩니다. 정확히는 주소는 변경되는데, 페이지 리프레시가 일어나지 않아요. memo 같은 것을 사용한 것도 아니라서 추후에 디버깅이 필요합니다 ㅠㅠ
      • 해당 문제는 우선 window.location.replace()로 구현해놨어요

📸스크린샷

⚡️사용 방법

📎레퍼런스

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #214 (b2ce3f5) into main (c2a7d13) will decrease coverage by 1.73%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #214      +/-   ##
=========================================
- Coverage   10.79%   9.06%   -1.74%     
=========================================
  Files         149     158       +9     
  Lines        1491    1777     +286     
  Branches      231     282      +51     
=========================================
  Hits          161     161              
- Misses       1272    1539     +267     
- Partials       58      77      +19     
Impacted Files Coverage Δ
...ks/api/auth/useCheckEmailVerifiedStatusMutation.ts 0.00% <0.00%> (ø)
src/hooks/api/auth/useSignupSendEmailMutation.ts 0.00% <0.00%> (ø)
...ooks/api/sign-up/useCheckExistsNicknameMutation.ts 0.00% <0.00%> (ø)
.../hooks/api/sign-up/useCheckExistsSignupMutation.ts 0.00% <0.00%> (ø)
src/hooks/api/sign-up/useSignupMutation.ts 0.00% <0.00%> (ø)
src/hooks/common/useInternalRouter.ts 75.00% <ø> (ø)
src/pages/login/index.tsx 0.00% <0.00%> (ø)
src/pages/signup/email-verified.tsx 0.00% <0.00%> (ø)
src/pages/signup/index.tsx 0.00% <0.00%> (ø)
src/pages/signup/sent-email.tsx 0.00% <0.00%> (ø)
... and 31 more

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 13, 2022

This pull request introduces 1 alert when merging b2ce3f5 into 31f3450 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@ddarkr ddarkr merged commit d163bae into main May 13, 2022
@ddarkr ddarkr deleted the issue/159 branch May 13, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

로그인 폼 - 입력 안했을 때 체크 떠있는 문제 회원가입 - api mutation & 기능 연동
1 participant