Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nail down type & trait requirements, *especially* auto traits. #15

Closed
dequbed opened this issue Sep 11, 2022 · 0 comments
Closed

Nail down type & trait requirements, *especially* auto traits. #15

dequbed opened this issue Sep 11, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@dequbed
Copy link
Owner

dequbed commented Sep 11, 2022

We take in and pass out several different types; types which should have very clear trait bounds that allow us some future iteration without breaking semver too.

In general the last point implies that we should have more specific requirements for types that are passed to us and guarantee much less traits for types we pass out.

This issue is especially relevant for auto-traits (Send, Sync, Unpin, UnwindSafe, …) that can easily be accidentally removed and then constitute a hidden breaking semver change.

@dequbed dequbed added enhancement New feature or request help wanted Extra attention is needed labels Sep 11, 2022
@dequbed dequbed added this to the v2.0.0 milestone Sep 19, 2022
@dequbed dequbed closed this as completed in 05f1709 Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant