Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add --chrome-path option (#700) #704

Merged
merged 3 commits into from
Aug 22, 2023
Merged

feat(cli): add --chrome-path option (#700) #704

merged 3 commits into from
Aug 22, 2023

Conversation

sinedied
Copy link
Contributor

@sinedied sinedied commented Apr 3, 2023

No description provided.

@sinedied sinedied requested a review from a team as a code owner April 3, 2023 15:24
@CLAassistant
Copy link

CLAassistant commented Apr 3, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@Zidious
Copy link
Contributor

Zidious commented May 31, 2023

Hey @sinedied,

Thanks for the PR! Apologies the delay, we'll get get to reviewing it this week.

michael-siek
michael-siek previously requested changes Jun 13, 2023
View reviewed changes
packages/cli/src/lib/webdriver.ts Outdated Show resolved Hide resolved
straker
straker previously requested changes Jul 10, 2023
View reviewed changes
packages/cli/src/bin/cli.ts Outdated Show resolved Hide resolved
@straker straker mentioned this pull request Jul 31, 2023
Open
1 task
@Zidious
Copy link
Contributor

Zidious commented Aug 8, 2023

Hey @sinedied,

Just checking up on the status of this PR or you need us to take this over?

Thanks again!

sinedied and others added 2 commits August 9, 2023 11:52
@sinedied
feat(cli): add --chrome-path option (dequelabs#700)
31fcade
@sinedied @straker
refactor: rename option description
be2dd3e 
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
@sinedied
Copy link
Contributor Author

sinedied commented Aug 9, 2023

Thanks @Zidious for the reminder!
I forgot about it as I was in vacation during the last notification, oups... I made the requested changes and rebased the branch, should be good now

@straker straker dismissed stale reviews from michael-siek and themself August 9, 2023 15:00

Resolved

@straker straker mentioned this pull request Aug 9, 2023
Merged
@Zidious
Copy link
Contributor

Zidious commented Aug 22, 2023

Hey @sinedied,

We should have CI up and running on contributor PR's soon and we'll be able to merge in your PR.

Thanks again!

@straker
Copy link
Contributor

straker commented Aug 22, 2023

Thanks again for the contribution.

Approved for security.

@straker straker merged commit ada5d28 into dequelabs:develop Aug 22, 2023
25 of 26 checks passed
This was referenced Aug 24, 2023
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 5, 2023
Closed
Closed
@straker straker mentioned this pull request Sep 11, 2023
Closed
@attest-team-ci attest-team-ci mentioned this pull request Sep 28, 2023
Closed
@michael-siek michael-siek mentioned this pull request Sep 28, 2023
Merged
@axe-core axe-core mentioned this pull request Oct 12, 2023
Closed
@github-actions github-actions bot mentioned this pull request Oct 12, 2023
Closed
@dequejenn dequejenn mentioned this pull request Oct 13, 2023
Merged
@snykbotzup snykbotzup mentioned this pull request Mar 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

@michael-siek michael-siek michael-siek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sinedied @CLAassistant @Zidious @straker @michael-siek