Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria.isValidRole should take abstract roles into consideration #1014

Closed
WilcoFiers opened this issue Jul 18, 2018 · 0 comments · Fixed by #1015
Closed

aria.isValidRole should take abstract roles into consideration #1014

WilcoFiers opened this issue Jul 18, 2018 · 0 comments · Fixed by #1015
Assignees

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Jul 18, 2018

Most of the time when we call aria.isValidRole, we're trying to test if an element's role was changed. Since abstract roles are ignored by AT (there is nothing they map to in the accessibility API, so I'm making the assumption that they do), setting an abstract role should be treated the same way as setting an invalid role. There are a number of places where we're not doing that.

I'm working on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant