Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reporter): adds the rawEnv reporter which wraps raw and env data #1556

Merged
merged 1 commit into from
May 10, 2019

Conversation

AutoSponge
Copy link
Contributor

@AutoSponge AutoSponge commented May 9, 2019

rawEnv reporter calls the callback with {raw, env} where raw is the output of the raw reporter and env is the output of helpers.getEnvironmentData().

Closes issue: #1534

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

straker
straker previously requested changes May 9, 2019
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to ensure the results.env contains some expected properties? Right now you could swap out the env call for an empty object and it would still pass.

Ditto for the results.raw array

@AutoSponge AutoSponge force-pushed the feat-raw-env-1534 branch 3 times, most recently from c189517 to d251e0b Compare May 10, 2019 12:55
@WilcoFiers
Copy link
Contributor

I'm created an issue #1560 for our lack of documentation about available reporters.

@WilcoFiers WilcoFiers merged commit ed15ed3 into develop May 10, 2019
@WilcoFiers WilcoFiers deleted the feat-raw-env-1534 branch May 10, 2019 15:20
stephenmathieson added a commit to mohanraj-r/axe-core that referenced this pull request May 10, 2019
* develop:
  feat(reporter): adds the rawEnv reporter which wraps raw and env data (dequelabs#1556)
  chore(i18n): Update Japanese locale (dequelabs#1549)
  fix(utils): make cache global instead of only setup in axe.run (dequelabs#1535)
  fix(aria-required-attr): don't require aria-valuemin/max (dequelabs#1529)
  docs: fixed small errors (dequelabs#1545)
  fix: check if property exists in cache of flattenedTree (dequelabs#1536)
  chore: update standard-version dep (dequelabs#1555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants