Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aria-required-attr): don't require aria-valuemin/max #1529

Merged
merged 2 commits into from
May 9, 2019
Merged

fix(aria-required-attr): don't require aria-valuemin/max #1529

merged 2 commits into from
May 9, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Apr 30, 2019 •
edited by jeeyyy
Loading

Linked issue: #1500

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @JKODU

WilcoFiers
WilcoFiers previously requested changes May 1, 2019
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add integration tests showing these are allowed.

@straker straker self-assigned this May 1, 2019
@straker
Copy link
Contributor Author

straker commented May 2, 2019

Please add integration tests showing these are allowed.

I believe these already exist in https://github.com/dequelabs/axe-core/blob/develop/test/integration/rules/aria-allowed-attr/passes.html#L1291-L1317.

@straker straker dismissed WilcoFiers’s stale review May 6, 2019 14:22

Possibly resolved

@straker straker merged commit 80ae444 into develop May 9, 2019
@straker straker deleted the noRequiredValueMinMax branch May 9, 2019 16:37
stephenmathieson added a commit to mohanraj-r/axe-core that referenced this pull request May 10, 2019
@stephenmathieson
Merge branch 'develop' into patch-1
72dfa47 
* develop:
  feat(reporter): adds the rawEnv reporter which wraps raw and env data (dequelabs#1556)
  chore(i18n): Update Japanese locale (dequelabs#1549)
  fix(utils): make cache global instead of only setup in axe.run (dequelabs#1535)
  fix(aria-required-attr): don't require aria-valuemin/max (dequelabs#1529)
  docs: fixed small errors (dequelabs#1545)
  fix: check if property exists in cache of flattenedTree (dequelabs#1536)
  chore: update standard-version dep (dequelabs#1555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeeyyy jeeyyy jeeyyy approved these changes

@WilcoFiers WilcoFiers WilcoFiers left review comments

Assignees

@straker straker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@straker @WilcoFiers @jeeyyy