fix(utils): make cache global instead of only setup in axe.run #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmathieson
previously requested changes
May 7, 2019
|
Good call. I created an integration test for plugins following our own docs code https://github.com/dequelabs/axe-core/blob/develop/doc/plugins.md. The last test breaks in the develop branch, as was expected. |
stephenmathieson
approved these changes
May 9, 2019
stephenmathieson
added a commit
to mohanraj-r/axe-core
that referenced
this pull request
May 10, 2019
* develop: feat(reporter): adds the rawEnv reporter which wraps raw and env data (dequelabs#1556) chore(i18n): Update Japanese locale (dequelabs#1549) fix(utils): make cache global instead of only setup in axe.run (dequelabs#1535) fix(aria-required-attr): don't require aria-valuemin/max (dequelabs#1529) docs: fixed small errors (dequelabs#1545) fix: check if property exists in cache of flattenedTree (dequelabs#1536) chore: update standard-version dep (dequelabs#1555)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that a lot of things can call
axe.utils.getFlattenedTreewithout going throughaxe.run, including our own code when we cleanup plugins https://github.com/dequelabs/axe-core/blob/develop/lib/core/public/cleanup-plugins.js#L28. This caused the axe extensions to break.Moving the creation of the
nodeMapto the flatten tree code meant that the cache also had to exist at that point, which meant it was created in two different places (axe.runandgetFlattenedTree). I decided it was cleaner to create a global private cache that always existed and could be used anywhere for any code that needed it. That way you weren't restricted to go throughaxe.runto have the cache available.Linked issues: #1532
Reviewer checks
Required fields, to be filled out by PR reviewer(s)