fix: check if property exists in cache of flattenedTree #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the bug? Please explain. |
WilcoFiers
approved these changes
May 9, 2019
stephenmathieson
added a commit
to mohanraj-r/axe-core
that referenced
this pull request
May 10, 2019
* develop: feat(reporter): adds the rawEnv reporter which wraps raw and env data (dequelabs#1556) chore(i18n): Update Japanese locale (dequelabs#1549) fix(utils): make cache global instead of only setup in axe.run (dequelabs#1535) fix(aria-required-attr): don't require aria-valuemin/max (dequelabs#1529) docs: fixed small errors (dequelabs#1545) fix: check if property exists in cache of flattenedTree (dequelabs#1536) chore: update standard-version dep (dequelabs#1555)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a pairing session, noticed a bug with checking if a property already exists in the
_vNodeCacheofflattenedTree.Previously because of this line https://github.com/dequelabs/axe-core/pull/1536/files#diff-a4aba2b3f5c65ff940eb4c8060dc57dfL37, if
isFocusableis false, the utility function will be called. We should check if a cached value exists, rather than check againsttrueorfalse, given that the values of some of these cached functions are boolean.Closes issue: NA.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)