Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make multiple-label a best-practice rule #855

Closed
WilcoFiers opened this issue Apr 20, 2018 · 2 comments
Closed

Make multiple-label a best-practice rule #855

WilcoFiers opened this issue Apr 20, 2018 · 2 comments
Labels
fix Bug fixes rules Issue or false result from an axe-core rule

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Apr 20, 2018 •
edited
Loading

Instead of having the multiple-label check be part of the label rule, we should have a separate best-practice rule. Having a duplicate label may be a violation of WCAG, but it doesn't have to be.
@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule labels Apr 20, 2018
@kensgists kensgists mentioned this issue Aug 6, 2018
Closed
@jeeyyy
Copy link
Contributor

jeeyyy commented Sep 12, 2018

@WilcoFiers
Was looking to pick this up, but there is no duplicate-label check, did you mean multiple-label?

@WilcoFiers WilcoFiers changed the title Make duplicate-label a best-practice rule Make multiple-label a best-practice rule Nov 6, 2018
@jeeyyy jeeyyy mentioned this issue Nov 7, 2018
Merged
4 tasks
@jeeyyy
Copy link
Contributor

jeeyyy commented Nov 13, 2018

PR Merged. Closing issue.

@jeeyyy jeeyyy closed this as completed Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WilcoFiers @jeeyyy and others