Password re-entry during disconnects #48
Comments
|
Can we see a debug log? |
|
Here ya go. I manually disabled and enabled, then forced a network On 07/16/2015 02:37 PM, Michael McConville wrote:
Aaron Nieman |
|
|
Which keyring plugin are you using for saving credentials |
|
Gnome Keyring 1.25
Pidgin 2.10.3
Ubuntu 12.04.5 LTS
|
|
Does this happen with other accounts or just Facebook? |
|
Just Facebook. It also happens when my network connection resumes from
suspend.
|
|
Assuming it is not the first time you have logged into the account, the plugin should not be requesting as password at all. After the first login, the plugin relies on the session information from the authentication process, not the password. I will have to test pidgin with gnome-keyring. |
|
I have verified that the password remains intact while it is asking for
me to enter the password. It will not let me proceed without entering
the password.
|
|
I assume you are using pidgin-gnome-keyring? If so, can you run pidgin in console and see if it spits anything out to stderr? The pidgin-gnome-keyring plugin is neglecting to use the proper debugging utilities in libpurple. |
|
|
I forced a disconnection of my network to get a password entry for it. |
|
@adnieman can you confirm the plugin you're using is https://github.com/aebrahim/pidgin-gnome-keyring ? |
|
Yes I am. It is version 1.25.
|
|
I upgraded to 565fbae05259, and am now using the repository. The password issue still persists. I still have to re-enter the password on network disconnect. However during pidgin startup, it sees the password in the keyring just fine. Something is happening where the plugin is interacting with pidgin during network disconnect detection. Maybe the plugin thinks a disconnect is caused by a bad password? Just throwing that out there. Other than this issue, the plugin works as expected. |
|
Here is a video showing first load of Pidgin, then network disconnect, with password ask, and verification of keyring still containing the password. |
|
Given this project is still in progress, and I have many other protocol based things to implement, debugging a third party plugin is not on the top of the list. If you (or someone else) can tell me what the cause is, I will patch it, assuming it is an issue with this plugin. |
|
Okay, i've done some debugging. libpurple/account.c:1318-1324, in password = purple_account_get_password(account);
if ((password == NULL) &&
!(prpl_info->options & OPT_PROTO_NO_PASSWORD) &&
!(prpl_info->options & OPT_PROTO_PASSWORD_OPTIONAL))
purple_account_request_password(account, G_CALLBACK(request_password_ok_cb), G_CALLBACK(request_password_cancel_cb), account);
else
_purple_connection_new(account, FALSE, password);
The only plugins with optional/no password flags are XMPP, IRC, SILC, bonjour and zephyr. Those will work fine with your keyring plugin. The rest won't. It seems you only tested with XMPP, aside from purple-facebook. So, not our bug. Submit an issue to pidgin-gnome-keyring, and link them this comment. Good luck! |
|
The password is still intact. It only gets over written in the keyring when the password is re-entered. If I cancel the password entry, and close out pidgin, then re launch and re-enable, it logs into the facebook account. |
|
I meant the password of the in-memory PurpleAccount structure. But yeah, my assumption that this password always gets wiped may be incorrect (and i don't even have the But what I'm 100% sure about is that this affects every other plugin out there, and it's not our fault. |
|
I don't have this issue with any other plugin I use and they all use
Gnome Keyring.
|
|
What other plugins do you use? I only see jabber in the logs above |
|
I've used AIM, XMPP(Facebook) as well. I live in a place where we |
|
Issue still exists for me in newest versions. It is issue with purple-facebook or pidgin-gnome-keyring? You have an idea how to make this plugins to cooperate? We should open issue on pidgin-gnome-keyring? |
|
Quoting myself in the comment before closing this issue:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am using version 305f27dd23c0
I've had to re-enter the password and I have checked save password. If I disable the account, and then re-enable, I have to re-enter. I know that the credentials are stored in the keyring. If I lose connection to the internet, and its restored, I am forced to re-enter the password. Is there a fix for this on the horizon?
The text was updated successfully, but these errors were encountered: