This fixes a Duplicate declaration error #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks. We need to keep the backwards compatibility. I am not through the release and upgrade notes for Puppet 6 - but we definitely need a switch depending on the client version here. |
JvGinkel
reviewed
Nov 4, 2018
| @@ -49,7 +49,7 @@ | |||
| content => $line, | |||
| } | |||
|
|
|||
| if ! defined(File[$name]) { | |||
| unless File["${name}"] { | |||
There was a problem hiding this comment.
This will fix your puppet-lint error, there is no need to quote a string that contains only a var
Suggested change
| unless File["${name}"] { | |
| unless File[$name] { |
|
fixed in 2.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On new versions of puppet the (! defined) does not seem to work any more. This is the preferred syntax.