Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] exo run receives all logs #390

Open
BenElgar opened this issue Oct 1, 2021 · 3 comments
Open

[BUG] exo run receives all logs #390

BenElgar opened this issue Oct 1, 2021 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@BenElgar
Copy link
Contributor

BenElgar commented Oct 1, 2021

Describe the bug
When running exo run you get all of the logs for the history of the workspace, not just the logs for the processes you just started.

@BenElgar BenElgar added bug Something isn't working needs triage Incoming request that needs to be triaged and prioritized labels Oct 1, 2021
@brandonbloom
Copy link
Member

Is this still true? And what precisely would you expect to happen?

It's not at all obvious what the right thing to do for logs of old components. Seems like you'd want logs to be somewhat immutable, but if you are applying a filter to set of components and a component changes... you probably want those filtered out.

If we can lock down what we think the best possible behavior is here, we can probably improve this. I suspect whatever improvements we do make though will have to wait until after we improve the system to be more event-driven.

@BenElgar
Copy link
Contributor Author

BenElgar commented Oct 7, 2021

Yes, it appears to still be true.

My expectation when running exo run would be that it only displays logs for the current run. I wouldn't expect it to display any historical logs. I don't necessarily have an issue with it displaying logs of old components so long as those components are actually running.

@brandonbloom
Copy link
Member

Ah, OK - I understand now. I think this might get implicitly fixed after we implement support for "stacks", since my tentative plan is for run to create a temporary/isolated stack, which will solve a bunch of the complexities around interactions between the gui, start, stop, event handling, etc. In such a world, each stack would have unique component ids, and therefore unique streams, so there would be no scrollback.

@brandonbloom brandonbloom removed the needs triage Incoming request that needs to be triaged and prioritized label Oct 9, 2021
@brandonbloom brandonbloom added this to the Overhaul milestone Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants